Add callback mechanism so that array_finalize can see if obj is Numba meminfo. #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mba_dppy.numpy_usm_shared can register with dpctl.dptensor.numpy_usm_shared.ndarray a callback function to look and see if the object is a Numba MemInfo with USM allocator.
PokhodenkoSA
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
LGTM.
As I understand there is commit in IntelPython/numba-dpex#50 on side of numba-dppy to add checker to the list of checkers via add_external_usm_checker().
Tested locally on Linux - works fine.
|
No tests for |
This was referenced Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to monkeypatch sycl__usm_array_interface into Numba's MemInfoObj as that object appears not to be monkeypatchable. Instead, I added a callback mechanism so that numba_dppy can register the previous code we had in array_finalize to check for USM MemInfo's. This way, we still have the same code but without Numba occurring explicitly in dpctl.