Skip to content

Decide which kernels to submit outside of handler functions in in gemm #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Moved logic of submitting different kernels in gemm outside of handler function

This should improve debugging experience, where one can see in the debugger which branch the execution took.

No other logic has been changed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

…r function

This should improve debugging experience, where one can see in the debugger which
branch the execution took.

No other logic has been changed.
Copy link

github-actions bot commented Feb 5, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.065%. remained the same
when pulling f7188ce on minimize-branching-in-handler-function
into 89266a7 on master.

Copy link

github-actions bot commented Feb 5, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_71 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2df8ccd into master Feb 6, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the minimize-branching-in-handler-function branch February 6, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants