Skip to content

Removes deprecated DPCTLDevice_GetMaxWorkItemSizes #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

Removes deprecated DPCTLDevice_GetMaxWorkItemSizes #1359

merged 1 commit into from
Aug 21, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes gh-1358.

This change removes deprecated DPCTLDevice_GetMaxWorkItemSizes.

Added Null_DRef tests for DPCTLDevice_GetMaxWorkItemSizes1d, DPCTLDevice_GetMaxWorkItemSizes2d,
DPCTLDevice_GetMaxWorkItemSizes3d.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Closes gh-1358
bcefda7 
Removes deprecated DPCTLDevice_GetMaxWorkItemSizes.

Added Null_DRef tests for DPCTLDevice_GetMaxWorkItemSizes1d,
DPCTLDevice_GetMaxWorkItemSizes2d, DPCTLDevice_GetMaxWorkItemSizes3d
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1359/index.html

@coveralls
Copy link
Collaborator

coveralls commented Aug 21, 2023 •
edited
Loading

Coverage Status

coverage: 85.61% (+0.01%) from 85.598% when pulling bcefda7 on remove-DPCTLDevice_GetMaxWorkItemSizes into abc8c80 on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the remove-DPCTLDevice_GetMaxWorkItemSizes branch from 526e595 to bcefda7 Compare August 21, 2023 13:01
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_4 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit c3427b3 into master Aug 21, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the remove-DPCTLDevice_GetMaxWorkItemSizes branch August 21, 2023 19:09
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_5 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Sep 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated DPCTLDevice_GetMaxWorkItemSizes
2 participants
@oleksandr-pavlyk @coveralls