Skip to content

Fix for reshape-related bugs #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

Fix for reshape-related bugs #1198

merged 1 commit into from
May 5, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes gh-1196.
Closes gh-1197.

The gh-1196 has to do with handling high dimensionality of arrays, while gh-1197 has to do with handling zero-size target arrays.

Tests covering examples from both tickets are added.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Fix for reshape-related bugs
c5687db 
Resolves gh-1196 and gh-1197. The 1196 has to do with handling high dimensionality
of arrays, while gh-1197 has to do with handling zero-size target arrays.

Tests covering examples from both tickets are added.
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 83.283% (+0.02%) from 83.259% when pulling c5687db on fix-gh-1196-and-1197 into 2da47aa on master.

@github-actions
Copy link

github-actions bot commented May 4, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1198/index.html

@github-actions
Copy link

github-actions bot commented May 4, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_40 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

antonwolfy
antonwolfy approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both examples work now. Thanks a lot!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2280ae1 into master May 5, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gh-1196-and-1197 branch May 5, 2023 12:35
@github-actions
Copy link

github-actions bot commented May 5, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented May 5, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_40 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request May 8, 2023
Closed
oleksandr-pavlyk added a commit that referenced this pull request May 8, 2023
@oleksandr-pavlyk
Simplify_iteration_space was doing it incorrectly since gh-1198
eb97326 
For nd==1, and when simplifying iteration over multiple arrays,
strides should only change sign if all strides are negative.
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request May 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@oleksandr-pavlyk @coveralls @antonwolfy