Skip to content

Improved error handling for usm_ndarray.__setitem__ #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Improved error handling for usm_ndarray.__setitem__ #1146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dpctl/tensor/_usmarray.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,13 +1110,19 @@ cdef class usm_ndarray:
"converted to usm_ndarray"
)
else:
rhs_np = np.asarray(rhs)
if type_bytesize(rhs_np.dtype.num) < 0:
raise ValueError(
f"Input of type {type(rhs)} can not be "
"assigned to usm_ndarray because of "
f"unsupported data type '{rhs_np.dtype}'"
)
try:
rhs_np = np.asarray(rhs)
_copy_from_numpy_into(Xv, rhs_np)
except Exception:
raise ValueError(
f"Input of type {type(rhs)} could not be "
"converted to usm_ndarray"
"copied into dpctl.tensor.usm_ndarray"
)
return

Expand Down