Skip to content

Improve array API conformity #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Improve array API conformity #1110

merged 2 commits into from
Mar 13, 2023

Conversation

ndgrigorian
Copy link
Collaborator

Minor changes throughout dpctl to improve array API conformity.

Function signature changes to match array API
Notably introduces finfo_object subclass of np.finfo. finfo_objects return eps, max, min, and smallest_normal as Python floats.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

- tests adjusted for keyword argument changes
- Improves array API conformity
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.404% (+0.001%) from 82.403% when pulling 4012039 on array-api-cleanup into 5bfc097 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_8 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@ndgrigorian ndgrigorian marked this pull request as ready for review March 13, 2023 01:28
@oleksandr-pavlyk
Copy link
Contributor

oleksandr-pavlyk commented Mar 13, 2023

Just to be explicit, dpt.iinfo needs to no changes since it already returns struct with fields of type int.

@ndgrigorian ndgrigorian merged commit cecfdaa into master Mar 13, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_8 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@ndgrigorian ndgrigorian deleted the array-api-cleanup branch April 5, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants