Skip to content

Reordered DPCTL_USM_HOST and DPCTL_USM_SHARED #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2023
Merged

Reordered DPCTL_USM_HOST and DPCTL_USM_SHARED #1065

merged 5 commits into from
Feb 7, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Feb 7, 2023 •
edited
Loading

In compute follows data we stipulate DEVICE<SHARED<HOST for the usm_type coercion logic.
It makes sense to keep integral values associated with the enum consistent with that mental model.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2023 •
edited
Loading

Coverage Status

Coverage: 82.257% (+0.05%) from 82.208% when pulling b5b0be0 on reorder-usm-type-enum-values into 4ed654f on master.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_82 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1065/index.html

@oleksandr-pavlyk
Removign dpctl.enum_types.usm_type as unsused
f8c26dc
@oleksandr-pavlyk
Added _Memory.get_usm_type_enum
567d5cb 
Also static _Memory.get_pointer_type_enum(ptr, DPCTLSyclContextRef) which
returns an integer value implied by DPCTL_USM_TYPE struct.

Added tests to exercise get_pointer_type_enum. This is going to be
useful for numba_dpex work.
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_86 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_87 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6308866 into master Feb 7, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the reorder-usm-type-enum-values branch February 7, 2023 21:18
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_88 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_88 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

oleksandr-pavlyk added a commit that referenced this pull request Mar 6, 2023
@oleksandr-pavlyk
Fixed typo in CHANGELOG.txt
2409176 
A digit was missing in '#65'->'#1065'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls