Skip to content

CHORE: Factored out _broadcast_shape implementation #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

The implementation takes an iterable of shapes. This is useful for implementation of general broadcasting function.

Otherwise, no functional change.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

The implementation takes an iterable of shapes. This is useful for
implementation of general broadcasting function.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.081% (+0.005%) from 82.076% when pulling f9413c5 on chore-factor-out-broadcast_impl into 949711e on master.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: ?%. Remained the same when pulling f9413c5 on chore-factor-out-broadcast_impl into 949711e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_47 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit b17589e into master Jan 27, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the chore-factor-out-broadcast_impl branch January 27, 2023 22:00
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_47 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants