Skip to content

Simplify iteration tweak #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Simplify iteration tweak #1032

merged 3 commits into from
Jan 6, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR does not add new functionality, but cleans up C++ sources of copy-and-casting kernels.

  1. A routine to simplify iteration space always sets shape, src_strides and dst_strides pointers.
  2. Added const qualifiers for some arguments in implementation functions to simplify code and to better reflect the intent.
  3. Upgraded dpctl/tensor/libtensor/tests/test_copy.py script to run on Iris Xe without support for double precision floating point numbers and to comply with compute follows data.
  • Have you provided a meaningful PR description?

Fixed violations of CFD. Made it work on Iris Xe.
This change made it possible to remove some uses of const_cast and made
code simpler.

Also used #pragma unroll in specialized CopyAndCast kernel where
displacement is computed from multi-index.
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.191%. Remained the same when pulling eb153e6 on simplify-iteration-tweak into afa1b86 on master.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_11 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 47e4ae4 into master Jan 6, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the simplify-iteration-tweak branch January 6, 2023 03:31
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_11 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants