Skip to content

Change default_device_int_type to return 'l' for long. #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Change default_device_int_type to return 'l' (code for for long type).

This should make dpt.arange(10) be int32 on Windows.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This should make `dpt.arange(10)` be int32 on Windows.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.34% when pulling def4e2e on change-default-int-type-for-device into 7d1904c on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_20 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5510976 into master Dec 15, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the change-default-int-type-for-device branch December 15, 2022 22:48
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev0=py310h8c27c75_20 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants