Skip to content

MAINT Include tuple in 'utils/strided_iters.hpp' #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jjerphan
Copy link
Contributor

@jjerphan jjerphan commented Dec 6, 2022

Fixes #1007.

This include directive seems to have been forgotten and it is impossible for me to compile dpctl without it.


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This include directive seems to have been forgotten and it is impossible
for me to compile dpctl without it.
@coveralls
Copy link
Collaborator

coveralls commented Dec 6, 2022

Coverage Status

Coverage remained the same at 82.032% when pulling f75ccd8 on jjerphan:fix/include-tuple-utils-strided_iters into 8506b90 on IntelPython:master.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this @jjerphan

The change is the right one even though I do not see this compilation failure in my setup, nor in Github actions. Your set-up must be different either because dpctl is compiled from within mamba, or because you have different gcc toolchain version (I am using 9.4, and yours is likely 11.2).

The failure of pre-commit must be happenstance, likely caused by update of clang-format tool in the action image. In fact #1009 also fails pre-commit workflow due to clang-format.

@jjerphan
Copy link
Contributor Author

jjerphan commented Dec 6, 2022

Thanks for those pieces of feedback!

I confirm that the version of my gcc toolchain is 12.2.1:

$ gcc --version
gcc (GCC) 12.2.1 20221121 (Red Hat 12.2.1-4)
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@oleksandr-pavlyk
Copy link
Contributor

By the way, #1009 also failed to compile because of missing #include <tuple>. I therefore am going to merge this, rebase #1009 on top of the trunk, and merge that then.

@oleksandr-pavlyk
Copy link
Contributor

Is there a reason why you want to keep this as draft or can I promote it and merge?

@jjerphan jjerphan marked this pull request as ready for review December 6, 2022 15:15
@oleksandr-pavlyk oleksandr-pavlyk merged commit e02b00a into IntelPython:master Dec 6, 2022
@jjerphan
Copy link
Contributor Author

jjerphan commented Dec 6, 2022

Ah, I kept it as a draft because the tests were not done on GPU (something which is expected to do as indicated on the list).

@jjerphan jjerphan deleted the fix/include-tuple-utils-strided_iters branch December 6, 2022 15:16
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_25 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Copy link
Contributor

Since Intel GPUs are not yet available in agents servicing GitHub actions, we need to set-up a machine with a GPU hosting a GitHub runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error due to missing include of "tuple"
3 participants