-
Notifications
You must be signed in to change notification settings - Fork 30
MAINT Include tuple in 'utils/strided_iters.hpp' #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Include tuple in 'utils/strided_iters.hpp' #1008
Conversation
This include directive seems to have been forgotten and it is impossible for me to compile dpctl without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this @jjerphan
The change is the right one even though I do not see this compilation failure in my setup, nor in Github actions. Your set-up must be different either because dpctl
is compiled from within mamba
, or because you have different gcc
toolchain version (I am using 9.4, and yours is likely 11.2).
The failure of pre-commit must be happenstance, likely caused by update of clang-format
tool in the action image. In fact #1009 also fails pre-commit
workflow due to clang-format.
Thanks for those pieces of feedback! I confirm that the version of my
|
Is there a reason why you want to keep this as draft or can I promote it and merge? |
Ah, I kept it as a draft because the tests were not done on GPU (something which is expected to do as indicated on the list). |
Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_25 ran successfully. |
Since Intel GPUs are not yet available in agents servicing GitHub actions, we need to set-up a machine with a GPU hosting a GitHub runner. |
Fixes #1007.
This include directive seems to have been forgotten and it is impossible for me to compile dpctl without it.