Skip to content

Commit e1aef83

Browse files
authored
Doc improvements (#231)
* Added missing docstrings and updated to some of the existing ones for dpctl functions.
1 parent f4a281f commit e1aef83

File tree

2 files changed

+262
-38
lines changed

2 files changed

+262
-38
lines changed

dpctl-capi/source/dpctl_sycl_queue_manager.cpp

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,8 @@ QMgrHelper::getQueue (DPCTLSyclBackendType BETy,
236236
QRef = new queue(gpuQs[DNum]);
237237
break;
238238
}
239-
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO | DPCTLSyclDeviceType::DPCTL_GPU:
239+
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO |
240+
DPCTLSyclDeviceType::DPCTL_GPU:
240241
{
241242
auto l0GpuQs = get_level0_gpu_queues();
242243
if (DNum >= l0GpuQs.size()) {
@@ -316,7 +317,8 @@ QMgrHelper::setAsDefaultQueue (DPCTLSyclBackendType BETy,
316317
activeQ[0] = oclgpu_q[DNum];
317318
break;
318319
}
319-
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO | DPCTLSyclDeviceType::DPCTL_GPU:
320+
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO |
321+
DPCTLSyclDeviceType::DPCTL_GPU:
320322
{
321323
auto l0gpu_q = get_level0_gpu_queues();
322324
if (DNum >= l0gpu_q.size()) {
@@ -342,8 +344,8 @@ QMgrHelper::setAsDefaultQueue (DPCTLSyclBackendType BETy,
342344
/*!
343345
* Allocates a new sycl::queue by copying from the cached {cpu|gpu}_queues
344346
* vector. The pointer returned is now owned by the caller and must be properly
345-
* cleaned up. The helper function DPCTLDeleteSyclQueue() can be used is for that
346-
* purpose.
347+
* cleaned up. The helper function DPCTLDeleteSyclQueue() can be used is for
348+
* that purpose.
347349
*/
348350
__dpctl_give DPCTLSyclQueueRef
349351
QMgrHelper::pushSyclQueue (DPCTLSyclBackendType BETy,
@@ -383,7 +385,8 @@ QMgrHelper::pushSyclQueue (DPCTLSyclBackendType BETy,
383385
QRef = new queue(activeQ[get_active_queues().size()-1]);
384386
break;
385387
}
386-
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO | DPCTLSyclDeviceType::DPCTL_GPU:
388+
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO |
389+
DPCTLSyclDeviceType::DPCTL_GPU:
387390
{
388391
if (DNum >= get_level0_gpu_queues().size()) {
389392
// \todo handle error
@@ -447,7 +450,7 @@ size_t DPCTLQueueMgr_GetNumActivatedQueues ()
447450
* type combination.
448451
*/
449452
size_t DPCTLQueueMgr_GetNumQueues (DPCTLSyclBackendType BETy,
450-
DPCTLSyclDeviceType DeviceTy)
453+
DPCTLSyclDeviceType DeviceTy)
451454
{
452455
switch (BETy|DeviceTy)
453456
{
@@ -459,7 +462,8 @@ size_t DPCTLQueueMgr_GetNumQueues (DPCTLSyclBackendType BETy,
459462
{
460463
return QMgrHelper::get_opencl_gpu_queues().size();
461464
}
462-
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO | DPCTLSyclDeviceType::DPCTL_GPU:
465+
case DPCTLSyclBackendType::DPCTL_LEVEL_ZERO |
466+
DPCTLSyclDeviceType::DPCTL_GPU:
463467
{
464468
return QMgrHelper::get_level0_gpu_queues().size();
465469
}
@@ -485,8 +489,8 @@ DPCTLSyclQueueRef DPCTLQueueMgr_GetCurrentQueue ()
485489
* and device number. A runtime_error gets thrown if no such device exists.
486490
*/
487491
DPCTLSyclQueueRef DPCTLQueueMgr_GetQueue (DPCTLSyclBackendType BETy,
488-
DPCTLSyclDeviceType DeviceTy,
489-
size_t DNum)
492+
DPCTLSyclDeviceType DeviceTy,
493+
size_t DNum)
490494
{
491495
return QMgrHelper::getQueue(BETy, DeviceTy, DNum);
492496
}
@@ -506,8 +510,8 @@ bool DPCTLQueueMgr_IsCurrentQueue (__dpctl_keep const DPCTLSyclQueueRef QRef)
506510
*/
507511
__dpctl_give DPCTLSyclQueueRef
508512
DPCTLQueueMgr_SetAsDefaultQueue (DPCTLSyclBackendType BETy,
509-
DPCTLSyclDeviceType DeviceTy,
510-
size_t DNum)
513+
DPCTLSyclDeviceType DeviceTy,
514+
size_t DNum)
511515
{
512516
return QMgrHelper::setAsDefaultQueue(BETy, DeviceTy, DNum);
513517
}
@@ -517,8 +521,8 @@ DPCTLQueueMgr_SetAsDefaultQueue (DPCTLSyclBackendType BETy,
517521
*/
518522
__dpctl_give DPCTLSyclQueueRef
519523
DPCTLQueueMgr_PushQueue (DPCTLSyclBackendType BETy,
520-
DPCTLSyclDeviceType DeviceTy,
521-
size_t DNum)
524+
DPCTLSyclDeviceType DeviceTy,
525+
size_t DNum)
522526
{
523527
return QMgrHelper::pushSyclQueue(BETy, DeviceTy, DNum);
524528
}
@@ -536,8 +540,10 @@ void DPCTLQueueMgr_PopQueue ()
536540
* SYCL device.
537541
*/
538542
DPCTLSyclQueueRef
539-
DPCTLQueueMgr_GetQueueFromContextAndDevice (__dpctl_keep DPCTLSyclContextRef CRef,
540-
__dpctl_keep DPCTLSyclDeviceRef DRef)
543+
DPCTLQueueMgr_GetQueueFromContextAndDevice (
544+
__dpctl_keep DPCTLSyclContextRef CRef,
545+
__dpctl_keep DPCTLSyclDeviceRef DRef
546+
)
541547
{
542548
auto dev = unwrap(DRef);
543549
auto ctx = unwrap(CRef);

0 commit comments

Comments
 (0)