Skip to content

Commit df1c22f

Browse files
committed
Removed void overloads from reduction utilities
These were unused by dpctl
1 parent 24b54d7 commit df1c22f

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

dpctl/tensor/libtensor/include/utils/sycl_utils.hpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,7 @@ template <typename T, typename Op> struct IsSyclOp
9696
{
9797
static constexpr bool value =
9898
detail::IsContained<Op, sycl_ops<std::remove_const_t<T>>>::value ||
99-
detail::IsContained<Op, sycl_ops<std::add_const_t<T>>>::value ||
100-
detail::IsContained<Op, sycl_ops<void>>::value;
99+
detail::IsContained<Op, sycl_ops<std::add_const_t<T>>>::value;
101100
};
102101

103102
/*! @brief Find the smallest multiple of supported sub-group size larger than
@@ -212,9 +211,7 @@ template <typename Op, typename T, typename = void> struct GetIdentity
212211

213212
template <typename T, class Op>
214213
using IsMaximum = std::bool_constant<std::is_same_v<Op, sycl::maximum<T>> ||
215-
std::is_same_v<Op, sycl::maximum<void>> ||
216-
std::is_same_v<Op, Maximum<T>> ||
217-
std::is_same_v<Op, Maximum<void>>>;
214+
std::is_same_v<Op, Maximum<T>>>;
218215

219216
template <typename Op, typename T>
220217
struct GetIdentity<Op, T, std::enable_if_t<IsMaximum<T, Op>::value>>
@@ -244,9 +241,7 @@ struct GetIdentity<Op,
244241

245242
template <typename T, class Op>
246243
using IsMinimum = std::bool_constant<std::is_same_v<Op, sycl::minimum<T>> ||
247-
std::is_same_v<Op, sycl::minimum<void>> ||
248-
std::is_same_v<Op, Minimum<T>> ||
249-
std::is_same_v<Op, Minimum<void>>>;
244+
std::is_same_v<Op, Minimum<T>>>;
250245

251246
template <typename Op, typename T>
252247
struct GetIdentity<Op, T, std::enable_if_t<IsMinimum<T, Op>::value>>
@@ -275,9 +270,8 @@ struct GetIdentity<Op,
275270
// Plus
276271

277272
template <typename T, class Op>
278-
using IsPlus = std::bool_constant<
279-
std::is_same_v<Op, sycl::plus<T>> || std::is_same_v<Op, sycl::plus<void>> ||
280-
std::is_same_v<Op, std::plus<T>> || std::is_same_v<Op, std::plus<T>>>;
273+
using IsPlus = std::bool_constant<std::is_same_v<Op, sycl::plus<T>> ||
274+
std::is_same_v<Op, std::plus<T>>>;
281275

282276
// Identity
283277

0 commit comments

Comments
 (0)