Merge pull request #1100 from IntelPython/small-typo-in-strided-1d-iter

oleksandr-pavlyk · web-flow · commit d259247f3415 · 2023-03-05T12:42:49.000-06:00
Class Strided1DIndexer must used min(gid, size-1)
diff --git a/dpctl/tensor/libtensor/include/kernels/boolean_advanced_indexing.hpp b/dpctl/tensor/libtensor/include/kernels/boolean_advanced_indexing.hpp
@@ -105,7 +105,9 @@ struct Strided1DIndexer
 
     size_t operator()(size_t gid) const
     {
-        return static_cast<size_t>(offset + std::min<size_t>(gid, size) * step);
+        // ensure 0 <= gid < size
+        return static_cast<size_t>(offset +
+                                   std::min<size_t>(gid, size - 1) * step);
     }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,9 @@ struct Strided1DIndexer`
`105`	`105`
`106`	`106`	`size_t operator()(size_t gid) const`
`107`	`107`	`{`
`108`		`- return static_cast<size_t>(offset + std::min<size_t>(gid, size) * step);`
	`108`	`+ // ensure 0 <= gid < size`
	`109`	`+ return static_cast<size_t>(offset +`
	`110`	`+ std::min<size_t>(gid, size - 1) * step);`
`109`	`111`	`}`
`110`	`112`
`111`	`113`	`private:`