Skip to content

Commit cffdb61

Browse files
Revert "Use linker scripts instead of symlink. (#472)"
This reverts commit 368911d.
1 parent 368911d commit cffdb61

File tree

1 file changed

+11
-23
lines changed

1 file changed

+11
-23
lines changed

dpctl-capi/CMakeLists.txt

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -147,36 +147,24 @@ target_link_libraries(DPCTLSyclInterface
147147
PRIVATE ${IntelSycl_OPENCL_LIBRARY}
148148
)
149149

150-
include(GetProjectVersion)
151-
# the get_version function is defined in the GetProjectVersion module and
152-
# defines: VERSION, SEMVER, MAJOR, MINOR, PATCH. These variables are populated
153-
# by parsing the output of git describe.
154-
get_version()
155-
set_target_properties(DPCTLSyclInterface
156-
PROPERTIES
157-
VERSION ${VERSION_MAJOR}.${VERSION_MINOR}
158-
SOVERSION ${VERSION_MAJOR}.${VERSION_MINOR}
159-
)
160-
161-
if(UNIX)
162-
set(linker_script1
163-
"INPUT(libDPCTLSyclInterface.so.${VERSION_MAJOR}.${VERSION_MINOR})"
164-
)
165-
add_custom_command(TARGET DPCTLSyclInterface POST_BUILD
166-
COMMAND "${CMAKE_COMMAND}" -E remove "libDPCTLSyclInterface.so"
167-
COMMAND "${CMAKE_COMMAND}"
168-
-E echo "${linker_script1}" > "libDPCTLSyclInterface.so"
169-
VERBATIM
170-
)
171-
endif()
172-
173150
if(DPCTL_ENABLE_LO_PROGRAM_CREATION)
174151
target_include_directories(DPCTLSyclInterface
175152
PRIVATE
176153
${LEVEL_ZERO_INCLUDE_DIR}
177154
)
178155
endif()
179156

157+
# FIXME: Turning off for release until conda build can be packaging symbolic links
158+
# NOTE: Till we hit 1.0.0 we will keep using the MINOR version to set the API
159+
# version of the library.
160+
# include(GetProjectVersion)
161+
# the get_version function is defined in the GetProjectVersion module and
162+
# defines: VERSION, SEMVER, MAJOR, MINOR, PATCH. These variables are populated
163+
# by parsing the output of git describe.
164+
# get_version()
165+
# set_target_properties(DPCTLSyclInterface PROPERTIES VERSION ${VERSION_MINOR})
166+
# set_target_properties(DPCTLSyclInterface PROPERTIES SOVERSION 1)
167+
180168
install(TARGETS
181169
DPCTLSyclInterface
182170
LIBRARY

0 commit comments

Comments
 (0)