address reviewer's comments

vtavana · vtavana · commit ac20262b93aa · 2023-07-24T13:05:35.000-05:00
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/exp.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/exp.hpp
@@ -89,7 +89,7 @@ template <typename argT, typename resT> struct ExpFunctor
                 }
             }
             else {
-                if (x > realT(0)) { /* x is +inf */
+                if (!std::signbit(x)) { /* x is +inf */
                     if (y == realT(0)) {
                         return resT{x, y};
                     }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ template <typename argT, typename resT> struct ExpFunctor`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`	`else {`
`92`		`- if (x > realT(0)) { /* x is +inf */`
	`92`	`+ if (!std::signbit(x)) { /* x is +inf */`
`93`	`93`	`if (y == realT(0)) {`
`94`	`94`	`return resT{x, y};`
`95`	`95`	`}`