Removed host-related functions/methods

Removed `DPCTLDevice_IsHost`, `DPCTLHostSelector_Create`,
`DPCTLContext_IsHost` and use of is_host from Python API.

Author: oleksandr-pavlyk

dpctl/_backend.pxd

@@ -172,7 +172,6 @@ cdef extern from "syclinterface/dpctl_sycl_device_interface.h":
     cdef bool DPCTLDevice_IsAccelerator(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsCPU(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_IsGPU(const DPCTLSyclDeviceRef DRef)
-    cdef bool DPCTLDevice_IsHost(const DPCTLSyclDeviceRef DRef)
     cdef bool DPCTLDevice_GetSubGroupIndependentForwardProgress(const DPCTLSyclDeviceRef DRef)
     cdef uint32_t DPCTLDevice_GetPreferredVectorWidthChar(const DPCTLSyclDeviceRef DRef)
     cdef uint32_t DPCTLDevice_GetPreferredVectorWidthShort(const DPCTLSyclDeviceRef DRef)

dpctl/_sycl_device.pyx

@@ -73,7 +73,6 @@ from ._backend cimport (  # noqa: E211
     DPCTLDevice_IsAccelerator,
     DPCTLDevice_IsCPU,
     DPCTLDevice_IsGPU,
-    DPCTLDevice_IsHost,
     DPCTLDeviceMgr_GetDeviceInfoStr,
     DPCTLDeviceMgr_GetDevices,
     DPCTLDeviceMgr_GetPositionInDevices,
@@ -710,15 +709,6 @@ cdef class SyclDevice(_SyclDevice):
         """
         return DPCTLDevice_IsGPU(self._device_ref)
 
-    @property
-    def is_host(self):
-        """ Returns True if the SyclDevice instance is a SYCL host device.
-
-        Returns:
-            bool: True if the SyclDevice is a SYCL host device, else False.
-        """
-        return DPCTLDevice_IsHost(self._device_ref)
-
     @property
     def max_work_item_dims(self):
         """ Returns the maximum dimensions that specify the global and local
@@ -847,11 +837,9 @@ cdef class SyclDevice(_SyclDevice):
             int: The maximum number of sub-groups support per work-group by
             the device.
         """
-        cdef uint32_t max_num_sub_groups = 0
-        if (not self.is_host):
-            max_num_sub_groups = (
-                DPCTLDevice_GetMaxNumSubGroups(self._device_ref)
-            )
+        cdef uint32_t max_num_sub_groups = (
+            DPCTLDevice_GetMaxNumSubGroups(self._device_ref)
+        )
         return max_num_sub_groups
 
     @property

dpctl/tests/_device_attributes_checks.py

@@ -108,7 +108,7 @@ def check_max_work_group_size(device):
 def check_max_num_sub_groups(device):
     max_num_sub_groups = device.max_num_sub_groups
     # Special case for FPGA simulator
-    if device.is_accelerator or device.is_host:
+    if device.is_accelerator:
         assert max_num_sub_groups >= 0
     else:
         assert max_num_sub_groups > 0
@@ -273,13 +273,6 @@ def check_is_gpu(device):
         pytest.fail("is_gpu call failed")
 
 
-def check_is_host(device):
-    try:
-        device.is_host
-    except Exception:
-        pytest.fail("is_hostcall failed")
-
-
 def check_max_read_image_args(device):
     try:
         device.max_read_image_args
@@ -563,7 +556,7 @@ def check_driver_version(device):
 
 def check_vendor(device):
     ve = device.vendor
-    assert ve or device.is_host
+    assert ve
     assert type(ve) is str
 
 
@@ -617,7 +610,6 @@ def check_global_mem_cache_line_size(device):
     check_is_accelerator,
     check_is_cpu,
     check_is_gpu,
-    check_is_host,
     check_sub_group_independent_forward_progress,
     check_preferred_vector_width_char,
     check_preferred_vector_width_short,

dpctl/tests/test_tensor_asarray.py

@@ -35,11 +35,6 @@
 )
 def test_asarray_change_usm_type(src_usm_type, dst_usm_type):
     d = dpctl.SyclDevice()
-    if d.is_host:
-        pytest.skip(
-            "Skip test of host device, which only "
-            "supports host USM allocations"
-        )
     X = dpt.empty(10, dtype="u1", usm_type=src_usm_type)
     Y = dpt.asarray(X, usm_type=dst_usm_type)
     assert X.shape == Y.shape

libsyclinterface/include/dpctl_sycl_context_interface.h

@@ -130,16 +130,6 @@ DPCTL_API
 __dpctl_give DPCTLDeviceVectorRef
 DPCTLContext_GetDevices(__dpctl_keep const DPCTLSyclContextRef CRef);
 
-/*!
- * @brief Returns true if this SYCL context is a host context.
- *
- * @param    CtxRef        An opaque pointer to a sycl::context.
- * @return   True if the SYCL context is a host context, else False.
- * @ingroup ContextInterface
- */
-DPCTL_API
-bool DPCTLContext_IsHost(__dpctl_keep const DPCTLSyclContextRef CtxRef);
-
 /*!
  * @brief Returns the sycl backend for the DPCTLSyclContextRef pointer.
  *

libsyclinterface/include/dpctl_sycl_device_interface.h

@@ -120,16 +120,6 @@ bool DPCTLDevice_IsCPU(__dpctl_keep const DPCTLSyclDeviceRef DRef);
 DPCTL_API
 bool DPCTLDevice_IsGPU(__dpctl_keep const DPCTLSyclDeviceRef DRef);
 
-/*!
- * @brief Returns true if this SYCL device is a host device.
- *
- * @param    DRef           Opaque pointer to a ``sycl::device``
- * @return   True if the device is a host device, else False.
- * @ingroup DeviceInterface
- */
-DPCTL_API
-bool DPCTLDevice_IsHost(__dpctl_keep const DPCTLSyclDeviceRef DRef);
-
 /*!
  * @brief Returns the backend for the device.
  *

libsyclinterface/include/dpctl_sycl_device_selector_interface.h

@@ -86,15 +86,6 @@ DPCTLFilterSelector_Create(__dpctl_keep const char *filter_str);
 DPCTL_API
 __dpctl_give DPCTLSyclDeviceSelectorRef DPCTLGPUSelector_Create(void);
 
-/*!
- * @brief Returns an opaque wrapper for dpctl_host_selector object.
- *
- * @return An opaque pointer to a dpctl_host_selector object.
- * @ingroup DeviceSelectors
- */
-DPCTL_API
-__dpctl_give DPCTLSyclDeviceSelectorRef DPCTLHostSelector_Create(void);
-
 /*!
  * @brief Deletes the DPCTLSyclDeviceSelectorRef after casting it to a
  * sycl::device_selector.

libsyclinterface/source/dpctl_sycl_context_interface.cpp

@@ -169,15 +169,6 @@ size_t DPCTLContext_DeviceCount(__dpctl_keep const DPCTLSyclContextRef CRef)
     return Devices.size();
 }
 
-bool DPCTLContext_IsHost(__dpctl_keep const DPCTLSyclContextRef CtxRef)
-{
-    auto Ctx = unwrap<context>(CtxRef);
-    if (Ctx) {
-        return false;
-    }
-    return false;
-}
-
 void DPCTLContext_Delete(__dpctl_take DPCTLSyclContextRef CtxRef)
 {
     delete unwrap<context>(CtxRef);

libsyclinterface/source/dpctl_sycl_device_interface.cpp

@@ -176,15 +176,6 @@ bool DPCTLDevice_IsGPU(__dpctl_keep const DPCTLSyclDeviceRef DRef)
     return false;
 }
 
-bool DPCTLDevice_IsHost(__dpctl_keep const DPCTLSyclDeviceRef DRef)
-{
-    auto D = unwrap<device>(DRef);
-    if (D) {
-        return false;
-    }
-    return false;
-}
-
 DPCTLSyclBackendType
 DPCTLDevice_GetBackend(__dpctl_keep const DPCTLSyclDeviceRef DRef)
 {

libsyclinterface/source/dpctl_sycl_device_selector_interface.cpp

@@ -97,17 +97,6 @@ __dpctl_give DPCTLSyclDeviceSelectorRef DPCTLGPUSelector_Create()
     }
 }
 
-__dpctl_give DPCTLSyclDeviceSelectorRef DPCTLHostSelector_Create()
-{
-    try {
-        auto Selector = new dpctl_host_selector();
-        return wrap<dpctl_device_selector>(Selector);
-    } catch (std::exception const &e) {
-        error_handler(e, __FILE__, __func__, __LINE__);
-        return nullptr;
-    }
-}
-
 int DPCTLDeviceSelector_Score(__dpctl_keep DPCTLSyclDeviceSelectorRef DSRef,
                               __dpctl_keep DPCTLSyclDeviceRef DRef)
 {

libsyclinterface/tests/test_sycl_context_interface.cpp

@@ -162,21 +162,6 @@ TEST_P(TestDPCTLContextInterface, ChkAreEq)
     EXPECT_NO_FATAL_FAILURE(DPCTLContext_Delete(CRef3));
 }
 
-TEST_P(TestDPCTLContextInterface, ChkIsHost)
-{
-    DPCTLSyclContextRef CRef = nullptr;
-    bool is_host_device = false, is_host_context = false;
-
-    EXPECT_NO_FATAL_FAILURE(CRef = DPCTLContext_Create(DRef, nullptr, 0));
-    ASSERT_TRUE(CRef);
-
-    EXPECT_NO_FATAL_FAILURE(is_host_device = DPCTLDevice_IsHost(DRef));
-    EXPECT_NO_FATAL_FAILURE(is_host_context = DPCTLContext_IsHost(CRef));
-    EXPECT_TRUE(is_host_device == is_host_context);
-
-    EXPECT_NO_FATAL_FAILURE(DPCTLContext_Delete(CRef));
-}
-
 TEST_P(TestDPCTLContextInterface, ChkGetBackend)
 {
     DPCTLSyclContextRef CRef = nullptr;
@@ -262,13 +247,6 @@ TEST_F(TestDPCTLContextNullArgs, ChkDeviceCount)
     ASSERT_TRUE(count == 0);
 }
 
-TEST_F(TestDPCTLContextNullArgs, ChkIsHost)
-{
-    bool is_host = true;
-    EXPECT_NO_FATAL_FAILURE(is_host = DPCTLContext_IsHost(Null_CRef));
-    ASSERT_FALSE(is_host);
-}
-
 TEST_F(TestDPCTLContextNullArgs, ChkHash)
 {
     size_t hash = 0;

libsyclinterface/tests/test_sycl_device_interface.cpp

@@ -242,11 +242,6 @@ TEST_P(TestDPCTLSyclDeviceInterface, ChkIsGPU)
     EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsGPU(DRef));
 }
 
-TEST_P(TestDPCTLSyclDeviceInterface, ChkIsHost)
-{
-    EXPECT_NO_FATAL_FAILURE(DPCTLDevice_IsHost(DRef));
-}
-
 TEST_P(TestDPCTLSyclDeviceInterface, ChkGetSubGroupIndependentForwardProgress)
 {
     bool sub_group_progress = 0;
@@ -528,13 +523,6 @@ TEST_F(TestDPCTLSyclDeviceNullArgs, ChkIsGPU)
     ASSERT_FALSE(is_gpu);
 }
 
-TEST_F(TestDPCTLSyclDeviceNullArgs, ChkIsHost)
-{
-    bool is_host = true;
-    EXPECT_NO_FATAL_FAILURE(is_host = DPCTLDevice_IsHost(Null_DRef));
-    ASSERT_FALSE(is_host);
-}
-
 TEST_F(TestDPCTLSyclDeviceNullArgs, ChkGetMaxComputeUnits)
 {
     uint32_t mcu = -1;

libsyclinterface/tests/test_sycl_device_selector_interface.cpp

@@ -159,27 +159,6 @@ TEST_F(TestDeviceSelectorInterface, ChkDPCTLGPUSelectorCreate)
     EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
 }
 
-TEST_F(TestDeviceSelectorInterface, ChkDPCTLHostSelectorCreate)
-{
-    DPCTLSyclDeviceSelectorRef DSRef = nullptr;
-    DPCTLSyclDeviceRef DRef = nullptr;
-
-    EXPECT_NO_FATAL_FAILURE(DSRef = DPCTLHostSelector_Create());
-    EXPECT_NO_FATAL_FAILURE(DRef = DPCTLDevice_CreateFromSelector(DSRef));
-
-    if (!DRef) {
-        EXPECT_NO_FATAL_FAILURE(DPCTLDeviceSelector_Delete(DSRef));
-        EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
-        GTEST_SKIP_("Device not found. Skip tests.");
-    }
-
-    EXPECT_NO_FATAL_FAILURE(DPCTLDeviceMgr_PrintDeviceInfo(DRef));
-    // FIXME: DPCPP's host_selector returns a CPU device for some reason.
-    // EXPECT_TRUE(DPCTLDevice_IsHost(DRef));
-    EXPECT_NO_FATAL_FAILURE(DPCTLDeviceSelector_Delete(DSRef));
-    EXPECT_NO_FATAL_FAILURE(DPCTLDevice_Delete(DRef));
-}
-
 TEST_P(TestFilterSelector, ChkDPCTLFilterSelectorCreate)
 {
     ASSERT_TRUE(DRef != nullptr);