Skip to content

Commit 920c0df

Browse files
profiling_info_submit was not property
This was gleaned by analyzing coverage (figuring out why that code was never called). Added tests to improve coverage.
1 parent 16bdf5b commit 920c0df

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

dpctl/_sycl_event.pyx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ cdef class SyclEvent(_SyclEvent):
323323
DPCTLEventVector_Delete(EVRef)
324324
return events
325325

326+
@property
326327
def profiling_info_submit(self):
327328
"""
328329
Returns the 64-bit time value in nanoseconds

dpctl/tests/test_sycl_event.py

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ def test_create_event_from_capsule():
7070
pytest.fail("Failed to create an event from capsule")
7171

7272

73+
def test_invalid_constructor_arg():
74+
with pytest.raises(TypeError):
75+
dpctl.SyclEvent(list())
76+
77+
7378
def test_wait_with_event():
7479
event = dpctl.SyclEvent()
7580
try:
@@ -83,6 +88,11 @@ def test_wait_with_event():
8388
pytest.fail("Failed to wait for the event")
8489

8590

91+
def test_wait_for_invalid():
92+
with pytest.raises(TypeError):
93+
dpctl.SyclEvent.wait_for(77)
94+
95+
8696
def test_wait_with_list():
8797
event_1 = dpctl.SyclEvent()
8898
event_2 = dpctl.SyclEvent()
@@ -101,11 +111,27 @@ def test_execution_status():
101111
assert event_status == esty.complete
102112

103113

114+
def test_execution_status_nondefault_event():
115+
event = produce_event()
116+
try:
117+
event_status = event.execution_status
118+
except ValueError:
119+
pytest.fail("Failed to get an event status")
120+
assert type(event_status) is esty
121+
wl = event.get_wait_list()
122+
assert type(wl) is list
123+
124+
104125
def test_backend():
105126
try:
106127
dpctl.SyclEvent().backend
107128
except ValueError:
108129
pytest.fail("Failed to get backend from event")
130+
event = produce_event()
131+
try:
132+
event.backend
133+
except ValueError:
134+
pytest.fail("Failed to get backend from event")
109135

110136

111137
@pytest.mark.skip(reason="event::get_wait_list() method returns wrong result")

0 commit comments

Comments
 (0)