Rewrites proj to use a custom implementation

- Avoids bug on CPU that results in incorrect result

Author: ndgrigorian

dpctl/tensor/__init__.py

@@ -100,15 +100,12 @@
     equal,
     exp,
     expm1,
-    imag,
     isfinite,
     isinf,
     isnan,
     log,
     log1p,
     multiply,
-    proj,
-    real,
     sin,
     sqrt,
 )
@@ -194,14 +191,11 @@
     "cos",
     "exp",
     "expm1",
-    "imag",
     "isinf",
     "isnan",
     "isfinite",
     "log",
     "log1p",
-    "proj",
-    "real",
     "sin",
     "sqrt",
     "divide",

dpctl/tensor/libtensor/include/kernels/elementwise_functions/proj.hpp

@@ -20,7 +20,7 @@
 //===---------------------------------------------------------------------===//
 ///
 /// \file
-/// This file defines kernels for elementwise evaluation of CONJ(x) function.
+/// This file defines kernels for elementwise evaluation of PROJ(x) function.
 //===---------------------------------------------------------------------===//
 
 #pragma once
@@ -29,6 +29,7 @@
 #include <complex>
 #include <cstddef>
 #include <cstdint>
+#include <limits>
 #include <type_traits>
 
 #include "kernels/elementwise_functions/common.hpp"
@@ -62,12 +63,19 @@ template <typename argT, typename resT> struct ProjFunctor
     // is function defined for sycl::vec
     using supports_vec = typename std::false_type;
     // do both argTy and resTy support sugroup store/load operation
-    using supports_sg_loadstore = typename std::negation<
-        std::disjunction<is_complex<resT>, is_complex<argT>>>;
+    using supports_sg_loadstore = typename std::false_type;
 
     resT operator()(const argT &in)
     {
-        return std::proj(in);
+        using realT = typename argT::value_type;
+        const realT x = std::real(in);
+        const realT y = std::imag(in);
+
+        if (std::isinf(x) || std::isinf(y)) {
+            const realT res_im = std::copysign(0.0, y);
+            return resT{std::numeric_limits<realT>::infinity(), res_im};
+        }
+        return in;
     }
 };
 
@@ -86,8 +94,6 @@ template <typename T> struct ProjOutputType
 {
     using value_type = typename std::disjunction< // disjunction is C++17
                                                   // feature, supported by DPC++
-        td_ns::TypeMapResultEntry<T, float, std::complex<float>>,
-        td_ns::TypeMapResultEntry<T, double, std::complex<double>>,
         td_ns::TypeMapResultEntry<T, std::complex<float>>,
         td_ns::TypeMapResultEntry<T, std::complex<double>>,
         td_ns::DefaultResultEntry<void>>::result_type;

dpctl/tensor/libtensor/source/elementwise_functions.cpp

@@ -37,39 +37,15 @@
 #include "kernels/elementwise_functions/conj.hpp"
 #include "kernels/elementwise_functions/cos.hpp"
 #include "kernels/elementwise_functions/equal.hpp"
-#include "kernels/elementwise_functions/isfinite.hpp"
-#include "kernels/elementwise_functions/isinf.hpp"
-#include "kernels/elementwise_functions/isnan.hpp"
-<<<<<<< HEAD
-=======
-<<<<<<< HEAD
-#include "kernels/elementwise_functions/log.hpp"
-#include "kernels/elementwise_functions/log1p.hpp"
-#include "kernels/elementwise_functions/multiply.hpp"
-#include "kernels/elementwise_functions/sin.hpp"
-=======
-<<<<<<< HEAD
-=======
-=======
-#include "kernels/elementwise_functions/expm1.hpp"
-=======
->>>>>>> 91c53d433... address reviewer comments
 #include "kernels/elementwise_functions/exp.hpp"
 #include "kernels/elementwise_functions/expm1.hpp"
-#include "kernels/elementwise_functions/imag.hpp"
 #include "kernels/elementwise_functions/isfinite.hpp"
 #include "kernels/elementwise_functions/isinf.hpp"
 #include "kernels/elementwise_functions/isnan.hpp"
 #include "kernels/elementwise_functions/log.hpp"
 #include "kernels/elementwise_functions/log1p.hpp"
 #include "kernels/elementwise_functions/multiply.hpp"
-#include "kernels/elementwise_functions/proj.hpp"
-#include "kernels/elementwise_functions/real.hpp"
 #include "kernels/elementwise_functions/sin.hpp"
->>>>>>> 94523d1ea... impl elementwise exp and sin
->>>>>>> 653e3b5a1... impl_real_imag_conj
->>>>>>> 74875eced... impl_real_imag_conj
->>>>>>> f12aeb6f1... impl_real_imag_conj
 #include "kernels/elementwise_functions/sqrt.hpp"
 #include "kernels/elementwise_functions/true_divide.hpp"