Skip to content

Commit 2abb03c

Browse files
Merge pull request #823 from IntelPython/remove-sycl-event-args
Remove unnecessary arg member of SyclEvent/_SyclEvent classes
1 parent abcfc5d commit 2abb03c

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

dpctl/_sycl_event.pxd

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ cdef public api class _SyclEvent [
3030
""" Data owner for SyclEvent
3131
"""
3232
cdef DPCTLSyclEventRef _event_ref
33-
cdef object args
3433

3534

3635
cdef public api class SyclEvent(_SyclEvent) [
@@ -40,7 +39,7 @@ cdef public api class SyclEvent(_SyclEvent) [
4039
""" Python wrapper class for a ``cl::sycl::event``
4140
"""
4241
@staticmethod
43-
cdef SyclEvent _create (DPCTLSyclEventRef event, object args=*)
42+
cdef SyclEvent _create (DPCTLSyclEventRef event)
4443
cdef int _init_event_default(self)
4544
cdef int _init_event_from__SyclEvent(self, _SyclEvent other)
4645
cdef int _init_event_from_capsule(self, object caps)

dpctl/_sycl_event.pyx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ cdef class _SyclEvent:
100100
if (self._event_ref):
101101
DPCTLEvent_Delete(self._event_ref)
102102
self._event_ref = NULL
103-
self.args = None
104103

105104

106105
cdef class SyclEvent(_SyclEvent):
@@ -140,7 +139,7 @@ cdef class SyclEvent(_SyclEvent):
140139
"""
141140

142141
@staticmethod
143-
cdef SyclEvent _create(DPCTLSyclEventRef eref, object args=None):
142+
cdef SyclEvent _create(DPCTLSyclEventRef eref):
144143
""""
145144
This function calls DPCTLEvent_Delete(eref).
146145
@@ -149,21 +148,18 @@ cdef class SyclEvent(_SyclEvent):
149148
"""
150149
cdef _SyclEvent ret = _SyclEvent.__new__(_SyclEvent)
151150
_init_helper(ret, eref)
152-
ret.args=args
153151
return SyclEvent(ret)
154152

155153
cdef int _init_event_default(self):
156154
self._event_ref = DPCTLEvent_Create()
157155
if (self._event_ref is NULL):
158156
return -1
159-
self.args=None
160157
return 0
161158

162159
cdef int _init_event_from__SyclEvent(self, _SyclEvent other):
163160
self._event_ref = DPCTLEvent_Copy(other._event_ref)
164161
if (self._event_ref is NULL):
165162
return -1
166-
self.args = other.args
167163
return 0
168164

169165
cdef int _init_event_from_capsule(self, object cap):
@@ -183,7 +179,6 @@ cdef class SyclEvent(_SyclEvent):
183179
if (ERef_copy is NULL):
184180
return -3
185181
self._event_ref = ERef_copy
186-
self.args = None
187182
return 0
188183
else:
189184
return -128
@@ -331,7 +326,7 @@ cdef class SyclEvent(_SyclEvent):
331326
events = []
332327
for i in range(num_events):
333328
ERef = DPCTLEventVector_GetAt(EVRef, i)
334-
events.append(SyclEvent._create(ERef, args=None))
329+
events.append(SyclEvent._create(ERef))
335330
DPCTLEventVector_Delete(EVRef)
336331
return events
337332

dpctl/_sycl_queue.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,7 @@ cdef class SyclQueue(_SyclQueue):
845845
# free memory
846846
free(arg_objects)
847847

848-
return SyclEvent._create(Eref, [])
848+
return SyclEvent._create(Eref)
849849

850850
cpdef void wait(self):
851851
with nogil: DPCTLQueue_Wait(self._queue_ref)
@@ -996,7 +996,7 @@ cdef class SyclQueue(_SyclQueue):
996996
"Barrier submission to Sycl queue failed."
997997
)
998998

999-
return SyclEvent._create(ERef, [])
999+
return SyclEvent._create(ERef)
10001000

10011001
@property
10021002
def name(self):

0 commit comments

Comments
 (0)