Adding tests to improve coverage

Removed tests expecting error raised in case of overlapping inputs.
Added tests guided by coverage report.

Author: oleksandr-pavlyk

dpctl/tests/elementwise/test_add.py

@@ -175,7 +175,7 @@ def test_add_broadcasting_new_shape():
     ).all()
 
     r3 = dpt.empty_like(ar1)
-    with pytest.raises(TypeError):
+    with pytest.raises(ValueError):
         dpt.add(ar1, ar2, out=r3)
 
     ar3 = dpt.ones((6, 1), dtype="i4")
@@ -273,7 +273,7 @@ def test_add_errors():
     ar2 = dpt.ones_like(ar1, sycl_queue=gpu_queue)
     y = dpt.empty_like(ar1, sycl_queue=cpu_queue)
     assert_raises_regex(
-        TypeError,
+        ExecutionPlacementError,
         "Input and output allocation queues are not compatible",
         dpt.add,
         ar1,
@@ -285,27 +285,14 @@ def test_add_errors():
     ar2 = dpt.ones_like(ar1, dtype="int32")
     y = dpt.empty(3)
     assert_raises_regex(
-        TypeError,
+        ValueError,
         "The shape of input and output arrays are inconsistent",
         dpt.add,
         ar1,
         ar2,
         y,
     )
 
-    ar1 = dpt.ones(2, dtype="float32")
-    ar2 = dpt.ones_like(ar1, dtype="int32")
-    # identical view but a different object
-    y = ar1[:]
-    assert_raises_regex(
-        TypeError,
-        "Input and output arrays have memory overlap",
-        dpt.add,
-        ar1,
-        ar2,
-        y,
-    )
-
     ar1 = np.ones(2, dtype="float32")
     ar2 = np.ones_like(ar1, dtype="int32")
     assert_raises_regex(
@@ -485,3 +472,48 @@ def test_add_inplace_same_tensors():
     dpt.add(ar1, ar2, out=ar2)
     # all ar2 vals should be 5
     assert (dpt.asnumpy(ar2) == np.full(ar2.shape, 5, dtype="i4")).all()
+
+
+def test_add_str_repr():
+    add_s = str(dpt.add)
+    assert isinstance(add_s, str)
+    assert "add" in add_s
+
+    add_r = repr(dpt.add)
+    assert isinstance(add_r, str)
+    assert "add" in add_r
+
+
+def test_add_cfd():
+    q1 = get_queue_or_skip()
+    q2 = dpctl.SyclQueue(q1.sycl_device)
+
+    x1 = dpt.ones(10, sycl_queue=q1)
+    x2 = dpt.ones(10, sycl_queue=q2)
+    with pytest.raises(ExecutionPlacementError):
+        dpt.add(x1, x2)
+
+    with pytest.raises(ExecutionPlacementError):
+        dpt.add(x1, x1, out=x2)
+
+
+def test_add_out_type_check():
+    get_queue_or_skip()
+
+    x1 = dpt.ones(10)
+    x2 = dpt.ones(10)
+
+    out = range(10)
+
+    with pytest.raises(TypeError):
+        dpt.add(x1, x2, out=out)
+
+
+def test_add_out_need_temporary():
+    get_queue_or_skip()
+
+    x = dpt.ones(10, dtype="u4")
+
+    dpt.add(x[:6], 1, out=x[-6:])
+
+    assert dpt.all(x[:-6] == 1) and dpt.all(x[-6:] == 2)