Skip to content

ColBERT Upstream Updates #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2023
Merged

ColBERT Upstream Updates #19

merged 2 commits into from
Jun 20, 2023

Conversation

danielfleischer
Copy link
Contributor

  • IndexUpdater class for adding/removing new documents from an existing index.
  • class_factory wrapper for HF_ColBERT to initializing new types of HF models:
    • AutoModel
    • BERT
    • Deberta
    • Electra
    • Roberta
    • XLMRoberta
  • Example in README.

@danielfleischer danielfleischer self-assigned this Jun 20, 2023
@danielfleischer danielfleischer requested a review from peteriz June 20, 2023 11:49
@danielfleischer danielfleischer added the enhancement New feature or request label Jun 20, 2023
- `IndexUpdater` class for adding/removing new documents from an existing index.
- `class_factory` wrapper for `HF_ColBERT` to initializing new types of models:
  - AutoModel
  - BERT
  - Deberta
  - Electra
  - Roberta
  - XLMRoberta
- Example in README.
Copy link
Contributor

@peteriz peteriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
any thoughts on updating the "updates" in the main readme?
plaid/colbert with newer models?

@danielfleischer
Copy link
Contributor Author

I can mention the new feature; support for HF models is in terms of classes compatibility, no new weights.

@danielfleischer danielfleischer merged commit 81b7a1a into main Jun 20, 2023
@danielfleischer danielfleischer deleted the colbert branch June 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants