Skip to content

Commit c5cc2d7

Browse files
hmonishNtensorflower-gardener
authored andcommitted
PR tensorflow#13872: Fix build issue for ir_emitter_triton_test
Imported from GitHub PR openxla/xla#13872 Build error is encountered in OSS for target ir_emitter_triton_test: #10 283.3 ./xla/service/memory_space_assignment/cost_analysis.h:118:28: note: replace 'default' with 'delete' #10 283.3 118 | HloCostAnalysisCosts() = default; #10 283.3 | ^~~~~~~ #10 283.3 | delete #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:1428:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 1428 | ASSERT_OK(backend_config_or); #10 283.3 | ^ #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:1442:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 1442 | ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config)); #10 283.3 | ^ #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:1460:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 1460 | ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config)); #10 283.3 | ^ #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:1975:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 1975 | ASSERT_OK(backend_config_or); #10 283.3 | ^ #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:1989:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 1989 | ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config)); #10 283.3 | ^ #10 283.3 xla/service/gpu/ir_emitter_triton_test.cc:2006:3: error: use of undeclared identifier 'ASSERT_OK' #10 283.3 2006 | ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config)); Fix: Replaced ASSERT_OK with TF_ASSERT_OK Copybara import of the project: -- f082bea2423cdeb3ffe369ab0702d27aa97d36dc by Harshit Monish <143435143+hmonishN@users.noreply.github.com>: Update ir_emitter_triton_test.cc replace ASSERT_OK with TF_ASSERT_OK Merging this change closes tensorflow#13872 PiperOrigin-RevId: 644187806
1 parent d110a8f commit c5cc2d7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

third_party/xla/xla/service/gpu/ir_emitter_triton_test.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1425,7 +1425,7 @@ ENTRY entry {
14251425

14261426
auto backend_config_or =
14271427
triton_dot_fusion->backend_config<GpuBackendConfig>();
1428-
ASSERT_OK(backend_config_or);
1428+
TF_ASSERT_OK(backend_config_or);
14291429
GpuBackendConfig& backend_config = *backend_config_or;
14301430

14311431
FusionBackendConfig& fusion_backend_config =
@@ -1439,7 +1439,7 @@ ENTRY entry {
14391439
config.set_num_warps(8);
14401440
config.set_num_stages(4);
14411441

1442-
ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
1442+
TF_ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
14431443

14441444
BlockLevelParameters block_level_parameters;
14451445
block_level_parameters.num_ctas = 1;
@@ -1457,7 +1457,7 @@ ENTRY entry {
14571457
config.set_block_n(128);
14581458
config.set_block_k(128);
14591459
block_level_parameters.num_stages = 1;
1460-
ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
1460+
TF_ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
14611461

14621462
TF_ASSERT_OK_AND_ASSIGN(
14631463
const auto result,
@@ -1972,7 +1972,7 @@ ENTRY entry {
19721972

19731973
auto backend_config_or =
19741974
triton_dot_fusion->backend_config<GpuBackendConfig>();
1975-
ASSERT_OK(backend_config_or);
1975+
TF_ASSERT_OK(backend_config_or);
19761976
GpuBackendConfig& backend_config = *backend_config_or;
19771977

19781978
FusionBackendConfig& fusion_backend_config =
@@ -1986,7 +1986,7 @@ ENTRY entry {
19861986
config.set_num_ctas(1);
19871987
config.set_num_stages(1);
19881988
config.set_num_warps(2);
1989-
ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
1989+
TF_ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
19901990

19911991
BlockLevelParameters block_level_parameters;
19921992
block_level_parameters.num_ctas = 1;
@@ -2003,7 +2003,7 @@ ENTRY entry {
20032003
config.set_block_m(32);
20042004
config.set_block_n(32);
20052005
config.set_block_k(32);
2006-
ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
2006+
TF_ASSERT_OK(triton_dot_fusion->set_backend_config(backend_config));
20072007

20082008
TF_CHECK_OK(TritonWrapper("test_fn", triton_dot_fusion, CudaAmpereOrRocm(),
20092009
dev_info, block_level_parameters, &llvm_module,

0 commit comments

Comments
 (0)