Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to Get Old Index Path for New Index Path in Update #672

Open
Adlai-Holler opened this issue Apr 18, 2017 · 7 comments
Open

Method to Get Old Index Path for New Index Path in Update #672

Adlai-Holler opened this issue Apr 18, 2017 · 7 comments

Comments

@Adlai-Holler
Copy link
Contributor

In https://github.com/TextureGroup/Texture we're looking to support using NodeControllers for each item, and having the NodeController survive across object updates (reloadItemsAtIndexPaths:) just like IGListSectionControllers do.

Since IGListKit submits reloads as delete/insert pairs, I can't see any public way for us to find out whether, in a given batch update, an insert corresponds to a delete – if an item was updated.

@rnystrom @jessesquires Would you be willing to support that or point me in the right direction?

@jessesquires
Copy link
Contributor

Is this the same as #546?

@Adlai-Holler
Copy link
Contributor Author

It's like that issue, except for reloads rather than moves.

@rnystrom
Copy link
Contributor

We could probably look into adding that after #657 lands. This is similar to #297 as well.

We can do this pretty easily w/out bothering to support UICollectionViewLayout (specifically UICollectionUpdateActionReload). We can add our new batch update reload pairs onto IGListBatchUpdateData.

@Adlai-Holler what sort of support are you thinking?

@jessesquires jessesquires added this to the 3.1.0 milestone Apr 19, 2017
@jessesquires
Copy link
Contributor

Currently seems additive, so marking this for 3.1

@rnystrom rnystrom modified the milestones: 3.2.0, 3.1.0 Aug 9, 2017
@rnystrom rnystrom modified the milestones: 3.2.0, 3.3.0 Feb 6, 2018
@jessesquires jessesquires modified the milestones: 3.3.0, 3.4.0 Apr 23, 2018
@jessesquires jessesquires modified the milestones: 3.4.0, 3.5.0 Jul 9, 2018
@jessesquires
Copy link
Contributor

Bumped this to new 3.5.0 milestone since 3.4.0 was released already.

@jessesquires jessesquires modified the milestones: 3.5.0, 4.0.0 Jul 9, 2018
@jessesquires
Copy link
Contributor

Nevermind, bumped to 4.0 since that's the next release. 😄

@iperry90
Copy link

Bumping this to 4.1.0 since we don't have a need for this at Instagram right now. We would be happy to review and accept a PR if anyone wants to take this on.

@iperry90 iperry90 modified the milestones: 4.0.0, 4.1.0 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants