Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Delete twice" test flaky because of bug in UICollectionView #651

Closed
rnystrom opened this issue Apr 17, 2017 · 2 comments
Closed

"Delete twice" test flaky because of bug in UICollectionView #651

rnystrom opened this issue Apr 17, 2017 · 2 comments
Assignees
@rnystrom
Labels
bug
Milestone
3.0.0

Comments

@rnystrom
Copy link
Contributor

rnystrom commented Apr 17, 2017 •
edited
Loading

Woot, we found another bug in UICollectionView! It looks like UICV has no problem handling multiple inserts at the same index path (e.g section = 0, item = 0) within the same batch update.

However if you try to delete from the same index path twice in a single batch update, things will eventually break.

This bug was exposed when we landed a415ef5 #483.

Here's a sample project demonstrating the issue. Radar time!

UICollectionViewMultipleDeletesSameIndex.zip
@rnystrom rnystrom added the bug label Apr 17, 2017
@rnystrom rnystrom self-assigned this Apr 17, 2017
@rnystrom
Copy link
Contributor Author

cc @amonshiz @jessesquires this explains some of the test flakiness (t17306420)

@jessesquires
Copy link
Contributor

@rnystrom Nice find!

Somebody call Steve 😄

@rnystrom rnystrom mentioned this issue Apr 17, 2017
Closed
3 tasks
@rnystrom rnystrom added this to the 3.0.0 milestone Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnystrom rnystrom

Labels
bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Prevent duplicate item deletes and drop reload collisions Instagram/IGListKit
2 participants
@rnystrom @jessesquires