Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emptyView Not Updated In Response to Item Updates #378

Closed
Adlai-Holler opened this issue Dec 29, 2016 · 4 comments
Closed

emptyView Not Updated In Response to Item Updates #378

Adlai-Holler opened this issue Dec 29, 2016 · 4 comments

Comments

@Adlai-Holler
Copy link
Contributor

Adlai-Holler commented Dec 29, 2016

Love the framework! I have a simple test app with a section controller that initially has 0 items, and after it loads content it calls insertInSectionController:atIndexes: to add some items. However, the list adapter never updates emptyView.hidden so there's a spinner behind the content!

In terms of a workaround, I can cast the collection context to IGListAdapter and call performUpdatesAnimated:completion: from inside the section controller. That'll trigger the empty view to update even though it's not beautiful.

Tested on a748e6f

@jessesquires
Copy link
Contributor

Thanks @Adlai-Holler ! 👍

Sounds like an edge-case that we've overlooked

@rnystrom
Copy link
Contributor

rnystrom commented Jan 4, 2017

Eek ya, good find. This should definitely be fixed and should be pretty easy to add a unit test for.

@edmonston
Copy link
Contributor

I'd love to take a crack at writing a fix & test(s) for this one over the weekend if no one is on it already...

@rnystrom
Copy link
Contributor

rnystrom commented Jan 6, 2017

@edmonston all yours!

@jessesquires jessesquires added this to the 2.2.0 milestone Jan 10, 2017
@jessesquires jessesquires modified the milestones: 2.2.0, 3.0.0 Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants