-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod subspec for 'IGListKit/Diffing' #365
Comments
cc @Sherlouk 😄 |
Aye yeah sorry was meant to update on this - had it working all the way up until the #imports which @rnystrom stressed he didn't want changing. Unfortunately any iOS usage expects all the relevant files like IGListAdapter.h, we'd need to do something a bit more clever than "if iOS import full IGListKit". Suggestions? |
Ah sorry, I missed some of that. I don't have much experience with subspecs. Here's the final behavior that I would want:
Is that possible? Do we have to have this other "IGListKit/CollectionView" spec? |
So that's exactly what I'm aiming for, but if you have the So if they use just the Diffing subspec, then certain files will be missing and thus won't build. https://github.com/Instagram/IGListKit/blob/master/Source/Common/IGListKit.h (Noting the if statement checking for iOS) |
Ahh I see... 🤔 |
Just had a nosey at SDWebImage's Podspec file and they add 'SD_WEBP=1' to the preprocessor and then can, seemingly, access that directly in their header file. We could do something similar, but otherwise I'm without idea how to achieve the desired effect! |
@Sherlouk Ah interesting! (I'm sure CP allows for this kind of thing. Maybe this is how.) What if we have a "common" umbrella header, |
@jessesquires Allow me to ensure we're on the same page: Having two header files:
If you use |
@Sherlouk - Exactly 😄 Is that possible? 🤔 |
@jessesquires - Will try and get it working tomorrow, and will also update README.md/relevant guides with info on how it works! Does sound like it would work, in theory. But we all know theory goes out the window when we're talking about all of this. 😂 |
Sounds good! I think a new guide in |
@Sherlouk I should clarify too, if we can find a way to make 2 specs, In fact that might even solve collisions when one library imports So #import <IGListDiffKit/IGListDiff.h> (sorry if I threw another wrench into things) |
@rnystrom I think I understand where you're coming from! I'm going to play around a little with it this morning and will see what actually works - will create a PR and can see whether the solution needs changing to work internally! |
@jessesquires Flagging for closure |
done in #368 |
See discussion here:
4e42712#commitcomment-20243693
The text was updated successfully, but these errors were encountered: