Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init overrides storyboard settings in IGListCollectionView. Should -[IGListCollectionView commonInit] be removed? #277

Closed
2 tasks done
dcaunt opened this issue Dec 2, 2016 · 1 comment
Labels
Milestone

Comments

@dcaunt
Copy link
Contributor

dcaunt commented Dec 2, 2016

New issue checklist

General information

  • IGListKit version: 1.0.0
  • iOS version(s): 10.1
  • CocoaPods/Carthage version:
  • Xcode version: 8.1
  • Devices/Simulators affected:
  • Reproducible in the demo project? (Yes/No):
  • Related issues: Add storyboard support #39 #92

The next release of IGListKit will support storyboards, but at present -[IGListCollectionView commonInit] sets a couple of options which override those provided by the storyboard.

I can open a PR to remove these if appropriate. The IB default appears to be white, but the example ViewControllers would need updating to explicitly set a background color in code.

@jessesquires
Copy link
Contributor

Ah, good find @dcaunt ! 💯

Yeah, let's do that and remove initWithCoder:

@jessesquires jessesquires added this to the 2.0.0 milestone Dec 2, 2016
@jessesquires jessesquires changed the title Should -[IGListCollectionView commonInit] be removed? Init overrides storyboard settings in IGListCollectionView. Should -[IGListCollectionView commonInit] be removed? Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants