-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow subclassing of IGListCollectionView? Remove IGLK_SUBCLASSING_RESTRICTED? #240
Comments
Hey @lucabartoletti 😄 In general, we've taken pretty firm stances against subclassing in the Insta codebase, which is why this macro exists.
|
Thanks for the reply @jessesquires On the long term I plan to implement a custom UICollectionViewLayout to achieve the same effect. I understand your point about IGLK_SUBCLASSING_RESTRICTED and your internal policy against subclassing. |
@lucabartoletti Feel free to also fork the project and remove the subclassing restriction if that's a requirement. Got any examples of the design you're trying to achieve with this? We're happy to help guide custom layout stuff 😃 |
Going to close this for now, since we're passing on changing this at the moment. Will re-open if there's more interest. |
Note, we're discussing this again in #409 |
In my project I have a CCTransparentTableView
It's a UITableView subclass that takes care to make the topMargin transparent to show what is behind.
I'm trying to substitute one of the CCTransparentTableView with a IGListCollectionView. The problem is that I'd like to reimplement the transparency logic in a CCTransparentCollectionView : IGListCollectionView and use it as IGListCollectionView. But IGLK_SUBCLASSING_RESTRICTED is blocking that.
Is IGLK_SUBCLASSING_RESTRICTED really necessary?
The text was updated successfully, but these errors were encountered: