[MOB-9962] Migrate to NativeEventEmitter
#924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
requested review from
TheBuggedYRN and
DavidMina96
and removed request for
TheBuggedYRN
7 tasks
a7medev
force-pushed
the
refactor/migrate-event-emitter
branch
from
d2ea5aa to
ad58a69
Compare
Generated by 🚫 Danger |
a7medev
force-pushed
the
chore/update-react-native
branch
from
e27126d to
33c93dc
Compare
a7medev
force-pushed
the
refactor/migrate-event-emitter
branch
from
3b18a02 to
504aff7
Compare
a7medev
force-pushed
the
refactor/migrate-event-emitter
branch
from
f0fff28 to
7a31551
Compare
a7medev
force-pushed
the
refactor/restructure-native
branch
from
18da13f to
39c9caa
Compare
a7medev
force-pushed
the
refactor/migrate-event-emitter
branch
from
fad603c to
fd1c16a
Compare
TheBuggedYRN
changed the title
NativeEventEmitterNativeEventEmitter
TheBuggedYRN
suggested changes
Mar 2, 2023
android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java
Show resolved
Hide resolved
Eliminates the use of event emitters in `NetworkLogger` by adding the callback in a global `_networkDataObfuscationHandler` variable and invoking it if it exists before logging the request
a7medev
force-pushed
the
refactor/migrate-event-emitter
branch
from
fd1c16a to
7c4f2e8
Compare
TheBuggedYRN
approved these changes
Mar 2, 2023
HeshamMegid
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Migrate the current IBGEventEmitter which uses the old NativeAppEventEmitter and DeviceEventEmitter to the new NativeEventEmitter which requires each module to have its own event emitter so the way we use emitter got restructured. * Eliminate NetworkLogger's event emitters usage by using callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Migrate the current
IBGEventEmitterwhich uses the oldNativeAppEventEmitterandDeviceEventEmitterto the newNativeEventEmitterwhich requires each module to have its own event emitter so the way we use emitter got restructured.Eliminate
NetworkLogger's event emitters usage by using callbacks.Type of change
Related issues
Checklists
Development
Code review