Skip to content

Commit cffd14d

Browse files
a7medevHeshamMegid
authored andcommitted
[MOB-12033] Restructure native Directory (#933)
* Restructure Native Directory * Remove commented code * Fix imports in mocks
1 parent aa89652 commit cffd14d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+84
-64
lines changed

src/models/Report.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Platform } from 'react-native';
22

3-
import { NativeInstabug } from '../native';
3+
import { NativeInstabug } from '../native/NativeInstabug';
44

55
interface LogInfo {
66
log: string;

src/models/Trace.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NativeAPM } from '../native';
1+
import { NativeAPM } from '../native/NativeAPM';
22

33
export default class Trace {
44
constructor(

src/modules/APM.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { Platform } from 'react-native';
22

33
import Trace from '../models/Trace';
4-
import { NativeAPM, NativeInstabug } from '../native';
4+
import { NativeAPM } from '../native/NativeAPM';
5+
import { NativeInstabug } from '../native/NativeInstabug';
56
import { logLevel } from '../utils/ArgsRegistry';
67

78
export { logLevel };

src/modules/BugReporting.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Platform } from 'react-native';
22

3-
import { NativeBugReporting } from '../native';
3+
import { NativeBugReporting } from '../native/NativeBugReporting';
44
import {
55
dismissType,
66
extendedBugReportMode,

src/modules/CrashReporting.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { Platform } from 'react-native';
22
import type { ExtendedError } from 'react-native/Libraries/Core/Devtools/parseErrorStack';
33

4-
import { NativeCrashReporting } from '../native';
5-
import type { CrashData } from '../native/CrashReportingNativeModule';
4+
import type { CrashData } from '../native/NativeCrashReporting';
5+
import { NativeCrashReporting } from '../native/NativeCrashReporting';
66
import InstabugUtils from '../utils/InstabugUtils';
77

88
/**

src/modules/FeatureRequests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NativeFeatureRequests } from '../native';
1+
import { NativeFeatureRequests } from '../native/NativeFeatureRequests';
22
import { actionTypes } from '../utils/ArgsRegistry';
33
import type { ActionType } from '../utils/Enums';
44

src/modules/Instabug.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import type { NavigationAction, NavigationState as NavigationStateV4 } from 'rea
77

88
import type { InstabugConfig } from '../models/InstabugConfig';
99
import Report from '../models/Report';
10-
import { NativeInstabug } from '../native';
10+
import { NativeInstabug } from '../native/NativeInstabug';
1111
import {
1212
IBGPosition,
1313
actionTypes,

src/modules/NetworkLogger.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { Platform } from 'react-native';
22

33
import type { RequestHandler } from '@apollo/client';
44

5-
import { NativeAPM, NativeInstabug } from '../native';
5+
import { NativeAPM } from '../native/NativeAPM';
6+
import { NativeInstabug } from '../native/NativeInstabug';
67
import IBGEventEmitter from '../utils/IBGEventEmitter';
78
import InstabugConstants from '../utils/InstabugConstants';
89
import xhr, { NetworkData, ProgressCallback } from '../utils/XhrNetworkInterceptor';

src/modules/Replies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Platform } from 'react-native';
22

3-
import { NativeReplies } from '../native';
3+
import { NativeReplies } from '../native/NativeReplies';
44
import IBGEventEmitter from '../utils/IBGEventEmitter';
55
import InstabugConstants from '../utils/InstabugConstants';
66

src/modules/Surveys.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Platform } from 'react-native';
22

3-
import { NativeSurveys } from '../native';
4-
import type { Survey } from '../native/SurveysNativeModule';
3+
import { NativeSurveys } from '../native/NativeSurveys';
4+
import type { Survey } from '../native/NativeSurveys';
55
import IBGEventEmitter from '../utils/IBGEventEmitter';
66
import InstabugConstants from '../utils/InstabugConstants';
77

src/native/ApmNativeModule.ts renamed to src/native/NativeAPM.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { NativeModule } from 'react-native';
22

33
import type { logLevel } from '../utils/ArgsRegistry';
4+
import { NativeModules } from './NativePackage';
45

56
export interface ApmNativeModule extends NativeModule {
67
// Essential APIs //
@@ -28,3 +29,5 @@ export interface ApmNativeModule extends NativeModule {
2829
/** @deprecated */
2930
setLogLevel(level: logLevel): void;
3031
}
32+
33+
export const NativeAPM = NativeModules.IBGAPM;

src/native/BugReportingNativeModule.ts renamed to src/native/NativeBugReporting.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import type {
1818
RecordingButtonPosition,
1919
ReportType,
2020
} from '../utils/Enums';
21+
import { NativeModules } from './NativePackage';
2122

2223
export interface BugReportingNativeModule extends NativeModule {
2324
// Essential APIs //
@@ -57,3 +58,5 @@ export interface BugReportingNativeModule extends NativeModule {
5758
handler: (dismissType: dismissType | DismissType, reportType: reportType | ReportType) => void,
5859
): void;
5960
}
61+
62+
export const NativeBugReporting = NativeModules.IBGBugReporting;

src/native/CrashReportingNativeModule.ts renamed to src/native/NativeCrashReporting.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import type { NativeModule, Platform } from 'react-native';
22
import type { StackFrame } from 'react-native/Libraries/Core/Devtools/parseErrorStack';
33

4+
import { NativeModules } from './NativePackage';
5+
46
export interface CrashData {
57
message: string;
68
e_message: string;
@@ -15,3 +17,5 @@ export interface CrashReportingNativeModule extends NativeModule {
1517
sendJSCrash(data: CrashData | string): void;
1618
sendHandledJSCrash(data: CrashData | string): void;
1719
}
20+
21+
export const NativeCrashReporting = NativeModules.IBGCrashReporting;

src/native/FeatureRequestsNativeModule.ts renamed to src/native/NativeFeatureRequests.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { NativeModule } from 'react-native';
22

33
import type { actionTypes } from '../utils/ArgsRegistry';
44
import type { ActionType } from '../utils/Enums';
5+
import { NativeModules } from './NativePackage';
56

67
export interface FeatureRequestsNativeModule extends NativeModule {
78
setEnabled(isEnabled: boolean): void;
@@ -11,3 +12,5 @@ export interface FeatureRequestsNativeModule extends NativeModule {
1112
types: actionTypes[] | ActionType[],
1213
): void;
1314
}
15+
16+
export const NativeFeatureRequests = NativeModules.IBGFeatureRequests;

src/native/InstabugNativeModule.ts renamed to src/native/NativeInstabug.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import type {
2121
} from '../utils/Enums';
2222
import type { NetworkData } from '../utils/XhrNetworkInterceptor';
2323
import type { NativeConstants } from './NativeConstants';
24+
import { NativeModules } from './NativePackage';
2425

2526
export interface InstabugNativeModule extends NativeModule {
2627
getConstants(): NativeConstants;
@@ -120,3 +121,5 @@ export interface InstabugNativeModule extends NativeModule {
120121
/** @deprecated */
121122
callPrivateApi(apiName: string, param: any[]): void;
122123
}
124+
125+
export const NativeInstabug = NativeModules.Instabug;

src/native/NativePackage.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { NativeModules as ReactNativeModules } from 'react-native';
2+
3+
import type { ApmNativeModule } from './NativeAPM';
4+
import type { BugReportingNativeModule } from './NativeBugReporting';
5+
import type { CrashReportingNativeModule } from './NativeCrashReporting';
6+
import type { FeatureRequestsNativeModule } from './NativeFeatureRequests';
7+
import type { InstabugNativeModule } from './NativeInstabug';
8+
import type { RepliesNativeModule } from './NativeReplies';
9+
import type { SurveysNativeModule } from './NativeSurveys';
10+
11+
export interface InstabugNativePackage {
12+
IBGAPM: ApmNativeModule;
13+
IBGBugReporting: BugReportingNativeModule;
14+
IBGCrashReporting: CrashReportingNativeModule;
15+
IBGFeatureRequests: FeatureRequestsNativeModule;
16+
Instabug: InstabugNativeModule;
17+
IBGReplies: RepliesNativeModule;
18+
IBGSurveys: SurveysNativeModule;
19+
}
20+
21+
export const NativeModules = ReactNativeModules as InstabugNativePackage;

src/native/RepliesNativeModule.ts renamed to src/native/NativeReplies.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import type { NativeModule } from 'react-native';
22

3+
import { NativeModules } from './NativePackage';
4+
35
export interface RepliesNativeModule extends NativeModule {
46
// Essential APIs //
57
setEnabled(isEnabled: boolean): void;
@@ -22,3 +24,5 @@ export interface RepliesNativeModule extends NativeModule {
2224
setPushNotificationChannelId(id: string): void;
2325
setSystemReplyNotificationSoundEnabled(isEnabled: boolean): void;
2426
}
27+
28+
export const NativeReplies = NativeModules.IBGReplies;

src/native/SurveysNativeModule.ts renamed to src/native/NativeSurveys.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import type { NativeModule } from 'react-native';
22

3+
import { NativeModules } from './NativePackage';
4+
35
export interface Survey {
46
title: string;
57
}
@@ -24,3 +26,5 @@ export interface SurveysNativeModule extends NativeModule {
2426
setOnShowHandler(onShowHandler: () => void): void;
2527
setOnDismissHandler(onDismissHandler: () => void): void;
2628
}
29+
30+
export const NativeSurveys = NativeModules.IBGSurveys;

src/native/index.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/utils/ArgsRegistry.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NativeInstabug } from '../native';
1+
import { NativeInstabug } from '../native/NativeInstabug';
22

33
const constants = NativeInstabug.getConstants();
44

src/utils/Enums.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NativeInstabug } from '../native';
1+
import { NativeInstabug } from '../native/NativeInstabug';
22

33
const constants = NativeInstabug.getConstants();
44

src/utils/InstabugUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import parseErrorStackLib, {
77
import type { NavigationState as NavigationStateV5, PartialState } from '@react-navigation/native';
88
import type { NavigationState as NavigationStateV4 } from 'react-navigation';
99

10-
import { NativeCrashReporting } from '../native';
11-
import type { CrashData } from '../native/CrashReportingNativeModule';
10+
import type { CrashData } from '../native/NativeCrashReporting';
11+
import { NativeCrashReporting } from '../native/NativeCrashReporting';
1212

1313
export const parseErrorStack = (error: ExtendedError): StackFrame[] => {
1414
return parseErrorStackLib(error);

test/mocks/mockAPM.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { ApmNativeModule } from '../../src/native/ApmNativeModule';
1+
import type { ApmNativeModule } from '../../src/native/NativeAPM';
22

33
const mockAPM: ApmNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockBugReporting.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { BugReportingNativeModule } from '../../src/native/BugReportingNativeModule';
1+
import type { BugReportingNativeModule } from '../../src/native/NativeBugReporting';
22

33
const mockBugReporting: BugReportingNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockCrashReporting.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { CrashReportingNativeModule } from '../../src/native/CrashReportingNativeModule';
1+
import type { CrashReportingNativeModule } from '../../src/native/NativeCrashReporting';
22

33
const mockCrashReporting: CrashReportingNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockFeatureRequests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { FeatureRequestsNativeModule } from '../../src/native/FeatureRequestsNativeModule';
1+
import type { FeatureRequestsNativeModule } from '../../src/native/NativeFeatureRequests';
22

33
const mockFeatureRequests: FeatureRequestsNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockInstabug.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { InstabugNativeModule } from '../../src/native/InstabugNativeModule';
1+
import type { InstabugNativeModule } from '../../src/native/NativeInstabug';
22

33
const mockInstabug: InstabugNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockNativeModules.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { InstabugNativePackage } from '../../src/native';
1+
import type { InstabugNativePackage } from '../../src/native/NativePackage';
22
import mockAPM from './mockAPM';
33
import mockBugReporting from './mockBugReporting';
44
import mockCrashReporting from './mockCrashReporting';

test/mocks/mockReplies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { RepliesNativeModule } from '../../src/native/RepliesNativeModule';
1+
import type { RepliesNativeModule } from '../../src/native/NativeReplies';
22

33
const mockReplies: RepliesNativeModule = {
44
addListener: jest.fn(),

test/mocks/mockSurveys.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { SurveysNativeModule } from '../../src/native/SurveysNativeModule';
1+
import type { SurveysNativeModule } from '../../src/native/NativeSurveys';
22

33
const mockSurveys: SurveysNativeModule = {
44
addListener: jest.fn(),

test/models/Report.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Platform } from 'react-native';
22

33
import Report from '../../src/models/Report';
4-
import { NativeInstabug } from '../../src/native';
4+
import { NativeInstabug } from '../../src/native/NativeInstabug';
55

66
describe('Report Model', () => {
77
let report: Report;

test/models/Trace.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Trace from '../../src/models/Trace';
2-
import { NativeAPM } from '../../src/native';
2+
import { NativeAPM } from '../../src/native/NativeAPM';
33

44
describe('Trace Model', () => {
55
it('should set the id, name and attributes if passed', () => {

test/modules/APM.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ import { mocked } from 'ts-jest/utils';
44

55
import Trace from '../../src/models/Trace';
66
import * as APM from '../../src/modules/APM';
7-
import { NativeAPM, NativeInstabug } from '../../src/native';
7+
import { NativeAPM } from '../../src/native/NativeAPM';
8+
import { NativeInstabug } from '../../src/native/NativeInstabug';
89

910
describe('APM Module', () => {
1011
it('should call the native method setEnabled', () => {

test/modules/BugReporting.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Platform } from 'react-native';
22

33
import * as BugReporting from '../../src/modules/BugReporting';
4-
import { NativeBugReporting } from '../../src/native';
4+
import { NativeBugReporting } from '../../src/native/NativeBugReporting';
55
import {
66
ExtendedBugReportMode,
77
FloatingButtonPosition,

test/modules/CrashReporting.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import '../mocks/mockInstabugUtils';
33
import { Platform } from 'react-native';
44

55
import * as CrashReporting from '../../src/modules/CrashReporting';
6-
import { NativeCrashReporting } from '../../src/native';
6+
import { NativeCrashReporting } from '../../src/native/NativeCrashReporting';
77

88
describe('CrashReporting Module', () => {
99
it('should call the native method setEnabled', () => {

test/modules/FeatureRequests.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as FeatureRequests from '../../src/modules/FeatureRequests';
2-
import { NativeFeatureRequests } from '../../src/native';
2+
import { NativeFeatureRequests } from '../../src/native/NativeFeatureRequests';
33
import { ActionType } from '../../src/utils/Enums';
44

55
describe('Feature Requests Module', () => {

test/modules/Instabug.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import waitForExpect from 'wait-for-expect';
66

77
import Report from '../../src/models/Report';
88
import * as Instabug from '../../src/modules/Instabug';
9-
import { NativeInstabug } from '../../src/native';
9+
import { NativeInstabug } from '../../src/native/NativeInstabug';
1010
import {
1111
ColorTheme,
1212
InvocationEvent,

test/modules/NetworkLogger.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ import { Platform } from 'react-native';
55
import waitForExpect from 'wait-for-expect';
66

77
import * as NetworkLogger from '../../src/modules/NetworkLogger';
8-
import { NativeAPM, NativeInstabug } from '../../src/native';
8+
import { NativeAPM } from '../../src/native/NativeAPM';
9+
import { NativeInstabug } from '../../src/native/NativeInstabug';
910
import IBGEventEmitter from '../../src/utils/IBGEventEmitter';
1011
import IBGConstants from '../../src/utils/InstabugConstants';
1112
import Interceptor from '../../src/utils/XhrNetworkInterceptor';

test/modules/Replies.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Platform } from 'react-native';
22

33
import * as Replies from '../../src/modules/Replies';
4-
import { NativeReplies } from '../../src/native';
4+
import { NativeReplies } from '../../src/native/NativeReplies';
55
import IBGEventEmitter from '../../src/utils/IBGEventEmitter';
66
import IBGConstants from '../../src/utils/InstabugConstants';
77

test/modules/Surveys.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Platform } from 'react-native';
22

33
import * as Surveys from '../../src/modules/Surveys';
4-
import { NativeSurveys } from '../../src/native';
4+
import { NativeSurveys } from '../../src/native/NativeSurveys';
55
import IBGEventEmitter from '../../src/utils/IBGEventEmitter';
66
import IBGConstants from '../../src/utils/InstabugConstants';
77

0 commit comments

Comments
 (0)