Skip to content

Commit 9b9b503

Browse files
committed
fix(ios): update network logging signature with empty w3c data
1 parent 3391ed4 commit 9b9b503

File tree

3 files changed

+26
-11
lines changed

3 files changed

+26
-11
lines changed

examples/default/ios/InstabugTests/InstabugSampleTests.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,12 @@ - (void)testNetworkLogIOS {
365365
startTime:startTime * 1000
366366
duration:duration * 1000
367367
gqlQueryName:gqlQueryName
368-
serverErrorMessage:serverErrorMessage]);
368+
serverErrorMessage:serverErrorMessage
369+
isW3cCaughted:nil
370+
partialID:nil
371+
timestamp:nil
372+
generatedW3CTraceparent:nil
373+
caughtedW3CTraceparent:nil]);
369374
}
370375

371376
- (void)testSetFileAttachment {

ios/RNInstabug/InstabugReactBridge.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,12 @@ - (dispatch_queue_t)methodQueue {
314314
startTime:startTime * 1000
315315
duration:duration * 1000
316316
gqlQueryName:gqlQueryName
317-
serverErrorMessage:serverErrorMessage];
317+
serverErrorMessage:serverErrorMessage
318+
isW3cCaughted:nil
319+
partialID:nil
320+
timestamp:nil
321+
generatedW3CTraceparent:nil
322+
caughtedW3CTraceparent:nil];
318323
}
319324

320325
RCT_EXPORT_METHOD(addPrivateView: (nonnull NSNumber *)reactTag) {

ios/RNInstabug/Util/IBGNetworkLogger+CP.h

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,27 @@ NS_ASSUME_NONNULL_BEGIN
55
@interface IBGNetworkLogger (CP)
66

77
+ (void)disableAutomaticCapturingOfNetworkLogs;
8-
+ (void)addNetworkLogWithUrl:(NSString *)url
9-
method:(NSString *)method
10-
requestBody:(NSString *)request
8+
+ (void)addNetworkLogWithUrl:(NSString *_Nonnull)url
9+
method:(NSString *_Nonnull)method
10+
requestBody:(NSString *_Nonnull)request
1111
requestBodySize:(int64_t)requestBodySize
12-
responseBody:(NSString *)response
12+
responseBody:(NSString *_Nonnull)response
1313
responseBodySize:(int64_t)responseBodySize
1414
responseCode:(int32_t)code
15-
requestHeaders:(NSDictionary *)requestHeaders
16-
responseHeaders:(NSDictionary *)responseHeaders
17-
contentType:(NSString *)contentType
18-
errorDomain:(NSString *)errorDomain
15+
requestHeaders:(NSDictionary *_Nonnull)requestHeaders
16+
responseHeaders:(NSDictionary *_Nonnull)responseHeaders
17+
contentType:(NSString *_Nonnull)contentType
18+
errorDomain:(NSString *_Nullable)errorDomain
1919
errorCode:(int32_t)errorCode
2020
startTime:(int64_t)startTime
2121
duration:(int64_t) duration
2222
gqlQueryName:(NSString * _Nullable)gqlQueryName
23-
serverErrorMessage:(NSString * _Nullable)serverErrorMessage;
23+
serverErrorMessage:(NSString * _Nullable)serverErrorMessage
24+
isW3cCaughted:(NSNumber * _Nullable)isW3cCaughted
25+
partialID:(NSNumber * _Nullable)partialID
26+
timestamp:(NSNumber * _Nullable)timestamp
27+
generatedW3CTraceparent:(NSString * _Nullable)generatedW3CTraceparent
28+
caughtedW3CTraceparent:(NSString * _Nullable)caughtedW3CTraceparent;
2429

2530
@end
2631

0 commit comments

Comments
 (0)