Skip to content

Commit 8d9036e

Browse files
committed
fix(ios): update network log signature
1 parent 261aa76 commit 8d9036e

File tree

6 files changed

+6
-16
lines changed

6 files changed

+6
-16
lines changed

examples/default/ios/InstabugTests/InstabugSampleTests.m

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ - (void)testNetworkLogIOS {
331331
double startTime = 1719847101199;
332332
double duration = 150;
333333
NSString *gqlQueryName = nil;
334-
NSString *serverErrorMessage = nil;
335334

336335
[self.instabugBridge networkLogIOS:url
337336
method:method
@@ -347,8 +346,7 @@ - (void)testNetworkLogIOS {
347346
errorCode:errorCode
348347
startTime:startTime
349348
duration:duration
350-
gqlQueryName:gqlQueryName
351-
serverErrorMessage:serverErrorMessage];
349+
gqlQueryName:gqlQueryName];
352350

353351
OCMVerify([mIBGNetworkLogger addNetworkLogWithUrl:url
354352
method:method
@@ -364,8 +362,7 @@ - (void)testNetworkLogIOS {
364362
errorCode:errorCode
365363
startTime:startTime * 1000
366364
duration:duration * 1000
367-
gqlQueryName:gqlQueryName
368-
serverErrorMessage:serverErrorMessage]);
365+
gqlQueryName:gqlQueryName]);
369366
}
370367

371368
- (void)testSetFileAttachment {

ios/RNInstabug/InstabugReactBridge.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@
120120
errorCode:(double)errorCode
121121
startTime:(double)startTime
122122
duration:(double)duration
123-
gqlQueryName:(NSString * _Nullable)gqlQueryName
124-
serverErrorMessage:(NSString * _Nullable)serverErrorMessage;
125-
123+
gqlQueryName:(NSString * _Nullable)gqlQueryName;
126124
/*
127125
+------------------------------------------------------------------------+
128126
| Experiments |

ios/RNInstabug/InstabugReactBridge.m

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,7 @@ - (dispatch_queue_t)methodQueue {
297297
errorCode:(double)errorCode
298298
startTime:(double)startTime
299299
duration:(double)duration
300-
gqlQueryName:(NSString * _Nullable)gqlQueryName
301-
serverErrorMessage:(NSString * _Nullable)serverErrorMessage) {
300+
gqlQueryName:(NSString * _Nullable)gqlQueryName) {
302301
[IBGNetworkLogger addNetworkLogWithUrl:url
303302
method:method
304303
requestBody:requestBody
@@ -313,8 +312,7 @@ - (dispatch_queue_t)methodQueue {
313312
errorCode:errorCode
314313
startTime:startTime * 1000
315314
duration:duration * 1000
316-
gqlQueryName:gqlQueryName
317-
serverErrorMessage:serverErrorMessage];
315+
gqlQueryName:gqlQueryName];
318316
}
319317

320318
RCT_EXPORT_METHOD(addPrivateView: (nonnull NSNumber *)reactTag) {

ios/RNInstabug/Util/IBGNetworkLogger+CP.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ NS_ASSUME_NONNULL_BEGIN
1919
errorCode:(int32_t)errorCode
2020
startTime:(int64_t)startTime
2121
duration:(int64_t) duration
22-
gqlQueryName:(NSString * _Nullable)gqlQueryName
23-
serverErrorMessage:(NSString * _Nullable)serverErrorMessage;
22+
gqlQueryName:(NSString * _Nullable)gqlQueryName;
2423

2524
@end
2625

src/native/NativeInstabug.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ export interface InstabugNativeModule extends NativeModule {
6666
startTime: number,
6767
duration: number,
6868
gqlQueryName: string | undefined,
69-
serverErrorMessage: string | undefined,
7069
): void;
7170

7271
setNetworkLoggingEnabled(isEnabled: boolean): void;

src/utils/InstabugUtils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ export function reportNetworkLog(network: NetworkData) {
191191
network.startTime,
192192
network.duration,
193193
network.gqlQueryName,
194-
network.serverErrorMessage,
195194
);
196195
}
197196
}

0 commit comments

Comments
 (0)