Skip to content

Commit 3b18a02

Browse files
committed
Fix Android tests
1 parent ad58a69 commit 3b18a02

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

android/src/main/java/com/instabug/reactlibrary/utils/EventEmitterModule.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.instabug.reactlibrary.utils;
22

33
import androidx.annotation.Nullable;
4+
import androidx.annotation.VisibleForTesting;
45

56
import com.facebook.react.bridge.ReactApplicationContext;
67
import com.facebook.react.bridge.ReactContextBaseJavaModule;
@@ -14,7 +15,8 @@ public EventEmitterModule(ReactApplicationContext context) {
1415
super(context);
1516
}
1617

17-
protected void sendEvent(String event, @Nullable WritableMap params) {
18+
@VisibleForTesting
19+
public void sendEvent(String event, @Nullable WritableMap params) {
1820
if (listenerCount > 0) {
1921
getReactApplicationContext()
2022
.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)

android/src/test/java/com/instabug/reactlibrary/RNInstabugBugReportingModuleTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,13 @@
3737
import static org.mockito.Mockito.doAnswer;
3838
import static org.mockito.Mockito.mock;
3939
import static org.mockito.Mockito.mockStatic;
40+
import static org.mockito.Mockito.spy;
4041
import static org.mockito.Mockito.verify;
4142
import static org.mockito.Mockito.when;
4243

4344
public class RNInstabugBugReportingModuleTest {
4445

45-
private RNInstabugBugReportingModule bugReportingModule = new RNInstabugBugReportingModule(mock(ReactApplicationContext.class));
46+
private RNInstabugBugReportingModule bugReportingModule = spy(new RNInstabugBugReportingModule(mock(ReactApplicationContext.class)));
4647
private final static ScheduledExecutorService mainThread = Executors.newSingleThreadScheduledExecutor();
4748

4849
// Mock Objects
@@ -240,8 +241,7 @@ public Object answer(InvocationOnMock invocation) {
240241
bugReportingModule.setOnInvokeHandler(null);
241242

242243
// then
243-
verify(InstabugUtil.class,VerificationModeFactory.times(1));
244-
InstabugUtil.sendEvent(any(ReactApplicationContext.class), eq(Constants.IBG_PRE_INVOCATION_HANDLER), Matchers.isNull(WritableMap.class));
244+
verify(bugReportingModule).sendEvent(Constants.IBG_PRE_INVOCATION_HANDLER, null);
245245
}
246246

247247

@@ -255,7 +255,6 @@ public Object answer(InvocationOnMock invocation) {
255255
when(Arguments.createMap()).thenReturn(new JavaOnlyMap());
256256
mockBugReporting.when(() -> BugReporting.setOnDismissCallback(any(OnSdkDismissCallback.class))).thenAnswer(new Answer() {
257257
public Object answer(InvocationOnMock invocation) {
258-
InstabugUtil.sendEvent(any(),any(),any());
259258
((OnSdkDismissCallback) invocation.getArguments()[0])
260259
.call(OnSdkDismissCallback.DismissType.CANCEL, OnSdkDismissCallback.ReportType.BUG);
261260
return null;
@@ -266,8 +265,7 @@ public Object answer(InvocationOnMock invocation) {
266265
WritableMap params = new JavaOnlyMap();
267266
params.putString("dismissType", OnSdkDismissCallback.DismissType.CANCEL.toString());
268267
params.putString("reportType", OnSdkDismissCallback.ReportType.BUG.toString());
269-
verify(InstabugUtil.class,VerificationModeFactory.times(1));
270-
InstabugUtil.sendEvent(any(ReactApplicationContext.class), eq(Constants.IBG_POST_INVOCATION_HANDLER), eq(params));
268+
verify(bugReportingModule).sendEvent(Constants.IBG_POST_INVOCATION_HANDLER, params);
271269
mockArgument.close();
272270
mockReactApplicationContext.close();
273271
}

android/src/test/java/com/instabug/reactlibrary/RNInstabugSurveysModuleTest.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.facebook.react.bridge.Callback;
88
import com.facebook.react.bridge.JavaOnlyArray;
99
import com.facebook.react.bridge.ReactApplicationContext;
10-
import com.facebook.react.bridge.WritableMap;
1110
import com.instabug.library.Feature;
1211
import com.instabug.reactlibrary.utils.InstabugUtil;
1312
import com.instabug.survey.Survey;
@@ -23,7 +22,6 @@
2322
import org.junit.After;
2423
import org.junit.Before;
2524
import org.junit.Test;
26-
import org.mockito.Matchers;
2725
import org.mockito.MockedStatic;
2826
import org.mockito.Mockito;
2927
import org.mockito.invocation.InvocationOnMock;
@@ -34,19 +32,17 @@
3432
import java.util.concurrent.ScheduledExecutorService;
3533

3634
import static org.mockito.Matchers.any;
37-
import static org.mockito.ArgumentMatchers.eq;
3835
import static org.mockito.Mockito.doAnswer;
3936
import static org.mockito.Mockito.mock;
4037
import static org.mockito.Mockito.mockStatic;
38+
import static org.mockito.Mockito.spy;
4139
import static org.mockito.Mockito.times;
4240
import static org.mockito.Mockito.verify;
4341

4442

4543
public class RNInstabugSurveysModuleTest {
4644

47-
private RNInstabugSurveysModule surveysModule = new RNInstabugSurveysModule(mock(ReactApplicationContext.class));
48-
49-
private final static ScheduledExecutorService mainThread = Executors.newSingleThreadScheduledExecutor();
45+
private RNInstabugSurveysModule surveysModule = spy(new RNInstabugSurveysModule(mock(ReactApplicationContext.class)));
5046

5147
// Mock Objects
5248
private MockedStatic<Looper> mockLooper;
@@ -180,8 +176,7 @@ public Object answer(InvocationOnMock invocation) {
180176
surveysModule.setOnShowHandler(null);
181177

182178
// then
183-
verify(InstabugUtil.class,times(1));
184-
InstabugUtil.sendEvent(any(ReactApplicationContext.class), eq(Constants.IBG_ON_SHOW_SURVEY_HANDLER), Matchers.isNull(WritableMap.class));
179+
verify(surveysModule).sendEvent(Constants.IBG_ON_SHOW_SURVEY_HANDLER, null);
185180
}
186181

187182
@Test
@@ -200,8 +195,7 @@ public Object answer(InvocationOnMock invocation) {
200195
surveysModule.setOnDismissHandler(null);
201196

202197
// then
203-
verify(InstabugUtil.class,times(1));
204-
InstabugUtil.sendEvent(any(ReactApplicationContext.class), eq(Constants.IBG_ON_DISMISS_SURVEY_HANDLER), Matchers.isNull(WritableMap.class));
198+
verify(surveysModule).sendEvent(Constants.IBG_ON_DISMISS_SURVEY_HANDLER, null);
205199
}
206200

207201
@Test

0 commit comments

Comments
 (0)