Skip to content

fix: resolve failing tests #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3b37268
release: 13.0.0
ahmedAlaaInstabug Apr 23, 2024
9756c70
fix: APM test case issue
ahmedAlaaInstabug Apr 23, 2024
ad38dce
fix: APM test case issue
ahmedAlaaInstabug Apr 23, 2024
1ff6f90
fix: APM test case issue
ahmedAlaaInstabug Apr 23, 2024
cf05fb9
fix: change-log typo
ahmedAlaaInstabug Apr 23, 2024
0e9bc5e
fix: change-log typo
ahmedAlaaInstabug Apr 23, 2024
2f4f68e
ci: fix appium issue
ahmedAlaaInstabug Apr 23, 2024
c1e99e8
ci: fix appium issue
ahmedAlaaInstabug Apr 23, 2024
d0fca5f
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
a62d1bd
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
710126e
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
16b3a9b
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
3b2b17c
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
eb99fb1
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
0983f14
fix: UI issue
ahmedAlaaInstabug Apr 23, 2024
2c153f5
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
e61690f
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
cd05d02
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
8321d2e
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
6bec88a
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
7156c9c
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
c87d116
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
2b49244
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
b875fc1
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
443f4e0
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
b056da8
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
a164d97
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
93e9a8f
fix: UI issue
ahmedAlaaInstabug Apr 24, 2024
e1fe040
fix: UI issue
ahmedAlaaInstabug Apr 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ commands:
steps:
- run:
name: Install XCUITest Driver
command: appium driver install xcuitest@4.35.0
command: appium driver install xcuitest@7.14.0
- when:
condition:
equal:
Expand All @@ -56,7 +56,7 @@ commands:
steps:
- run:
name: Install UIAutomator2 Driver
command: appium driver install uiautomator2@2.29.5
command: appium driver install uiautomator2@3.1.0
- run:
name: Launch Appium
# Enable --relaxed-security for `mobile: shell` command that Captain uses internally.
Expand Down Expand Up @@ -162,13 +162,14 @@ jobs:
- setup_flutter
- android/start-emulator-and-run-tests:
run-tests-working-directory: e2e
additional-avd-args: --device 3
system-image: system-images;android-33;default;x86_64
post-emulator-launch-assemble-command: cd example && flutter build apk --debug
test-command: dotnet test

test_ios:
macos:
xcode: 15.3.0
xcode: 15.2.0
resource_class: macos.m1.medium.gen1
environment:
INSTABUG_SOURCEMAPS_UPLOAD_DISABLE: true
Expand All @@ -184,12 +185,12 @@ jobs:
-scheme Runner \
-resultBundlePath coverage/result.xcresult \
-sdk iphonesimulator \
-destination 'platform=iOS Simulator,name=iPhone 15 Pro Max,OS=17.4' \
-destination 'platform=iOS Simulator,name=iPhone 15 Pro Max,OS=17.2' \
test | xcpretty

e2e_ios_captain:
macos:
xcode: 15.3.0
xcode: 15.2.0
resource_class: macos.m1.medium.gen1
steps:
- advanced-checkout/shallow-checkout
Expand Down Expand Up @@ -242,7 +243,7 @@ jobs:

release:
macos:
xcode: 15.3.0
xcode: 15.2.0
resource_class: macos.m1.medium.gen1
working_directory: "~"
steps:
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Added

- Adds custom app rating api ([#453](https://github.com/Instabug/Instabug-Flutter/pull/453))
- Add `SessionReplay.getSessionReplayLink` API which retrieves the current session's replay link ([#445](hhttps://github.com/Instabug/Instabug-Flutter/pull/445)).
- Add `SessionReplay.getSessionReplayLink` API which retrieves the current session's replay link ([#445](https://github.com/Instabug/Instabug-Flutter/pull/445)).
- Add support for App Flows APIs `APM.startFlow`, `APM.endFlow` and `APM.setFlowAttribute` ([#446](https://github.com/Instabug/Instabug-Flutter/pull/446)).

### Deprecated
Expand Down
5 changes: 5 additions & 0 deletions e2e/BugReportingTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public void ShakeInvocationEvent()
[Fact]
public void TwoFingersSwipeLeftInvocationEvent()
{
ScrollUp();
captain.FindByText("Two Fingers Swipe Left").Tap();

Thread.Sleep(500);
Expand Down Expand Up @@ -112,6 +113,8 @@ public void ManualInvocation()
[Fact]
public void MultipleScreenshotsInReproSteps()
{
ScrollDown();

captain.FindByText("Enter screen name").Tap();
captain.Type("My Screen");
captain.HideKeyboard();
Expand Down Expand Up @@ -189,6 +192,8 @@ public void ChangeFloatingButtonEdge()
[Fact]
public void OnDismissCallbackIsCalled()
{
ScrollUp();

captain.FindByText("Set On Dismiss Callback").Tap();
captain.FindByText("Invoke").Tap();

Expand Down
2 changes: 2 additions & 0 deletions e2e/FeatureRequestsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ public class FeatureRequestsTests : CaptainTest
public void ShowFeatureRequetsScreen()
{
ScrollDown();
ScrollDown();

captain.FindByText("Show Feature Requests").Tap();

var screenTitle = captain.FindById(
Expand Down
4 changes: 2 additions & 2 deletions e2e/Utils/CaptainTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ public class CaptainTest : IDisposable
{
AndroidApp = Path.GetFullPath("../../../../example/build/app/outputs/flutter-apk/app-debug.apk"),
AndroidAppId = "com.instabug.flutter.example",
AndroidVersion = "13",
AndroidVersion = "14",
IosApp = Path.GetFullPath("../../../../example/build/ios/iphonesimulator/Runner.app"),
IosAppId = "com.instabug.InstabugSample",
IosVersion = "17.4",
IosVersion = "17.2",
IosDevice = "iPhone 15 Pro Max"
};
protected static readonly Captain captain = new(_config);
Expand Down
2 changes: 1 addition & 1 deletion example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ android {

defaultConfig {
applicationId "com.instabug.flutter.example"
minSdkVersion 18
minSdkVersion flutter.minSdkVersion
targetSdkVersion 30
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
Expand Down
2 changes: 1 addition & 1 deletion example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
2 changes: 1 addition & 1 deletion example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ SPEC CHECKSUMS:
instabug_flutter: c8293ec7ad7ffe049c743a0057601838b8af505d
OCMock: 5ea90566be239f179ba766fd9fbae5885040b992

PODFILE CHECKSUM: 637e800c0a0982493b68adb612d2dd60c15c8e5c
PODFILE CHECKSUM: 4de1907d67185ba01b9d9c952bfb1b2c3b10d282

COCOAPODS: 1.13.0
26 changes: 12 additions & 14 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -170,17 +170,17 @@ class _MyHomePageState extends State<MyHomePage> {
Surveys.showSurvey('PMqUZXqarkOR2yGKiENB4w');
}

final _scaffoldKey=GlobalKey<ScaffoldState>();
final _scaffoldKey = GlobalKey<ScaffoldState>();

void getCurrentSessionReplaylink() async {
final result=await SessionReplay.getSessionReplayLink();
if(result==null){
final result = await SessionReplay.getSessionReplayLink();
if (result == null) {
const snackBar = SnackBar(
content: Text('No Link Found'),
);
ScaffoldMessenger.of(_scaffoldKey.currentContext!).showSnackBar(snackBar);
}else{
var snackBar = SnackBar(
} else {
var snackBar = SnackBar(
content: Text(result),
);
ScaffoldMessenger.of(_scaffoldKey.currentContext!).showSnackBar(snackBar);
Expand Down Expand Up @@ -225,7 +225,7 @@ class _MyHomePageState extends State<MyHomePage> {
appBar: AppBar(title: Text(widget.title)),
body: SingleChildScrollView(
physics: ClampingScrollPhysics(),
padding: const EdgeInsets.only(top: 20.0),
padding: const EdgeInsets.only(top: 20.0, bottom: 16),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Expand Down Expand Up @@ -360,7 +360,7 @@ class _MyHomePageState extends State<MyHomePage> {
),
SectionTitle('Color Theme'),
ButtonBar(
mainAxisSize: MainAxisSize.max,
mainAxisSize: MainAxisSize.min,
alignment: MainAxisAlignment.center,
children: <Widget>[
ElevatedButton(
Expand All @@ -380,15 +380,13 @@ class _MyHomePageState extends State<MyHomePage> {
),
child: const Text('Dark'),
),


SectionTitle('Sessions Replay'),
InstabugButton(
onPressed: getCurrentSessionReplaylink,
text: 'Get current session replay link',
),
],
),
SectionTitle('Sessions Replay'),
InstabugButton(
onPressed: getCurrentSessionReplaylink,
text: 'Get current session replay link',
),
],
)), // This trailing comma makes auto-formatting nicer for build methods.
);
Expand Down
Loading