Skip to content

fix: resolve failing tests #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Apr 28, 2024
Merged

fix: resolve failing tests #458

merged 29 commits into from
Apr 28, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  • Fix: test cases issues

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID : MOB-14375

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug requested a review from a team April 24, 2024 14:11
@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Apr 24, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Apr 24, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 86.1% ✅

Generated by 🚫 dangerJS against e1fe040

@a7medev a7medev changed the title Fix: test cases issues fix: resolve failing tests Apr 28, 2024
a7medev
a7medev approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼 Very good job fixing this! 👏🏼

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit d556899 into dev Apr 28, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the fix/ci_issues branch April 28, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @InstabugCI @a7medev