Skip to content

[MOB-11699] Support more Locales #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

[MOB-11699] Support more Locales #175

merged 2 commits into from
Feb 1, 2023

Conversation

@DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Jan 31, 2023 •
edited
Loading

Description of the change

  • Adds support for more locales and fixes some typos.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 changed the base branch from master to dev January 31, 2023 15:55
@DavidMina96 DavidMina96 self-assigned this Jan 31, 2023
@DavidMina96 DavidMina96 merged commit f2f8464 into dev Feb 1, 2023
@DavidMina96 DavidMina96 deleted the feature/support-more-locales branch February 1, 2023 09:21
HeshamMegid pushed a commit that referenced this pull request Feb 2, 2023
@DavidMina96 @HeshamMegid
[MOB-11699] Support more Locales (#175)
f40b6dc 
Adds support for more locales and fixes some typos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a7medev a7medev Awaiting requested review from a7medev

1 more reviewer

@TheBuggedYRN TheBuggedYRN TheBuggedYRN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DavidMina96 DavidMina96

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidMina96 @TheBuggedYRN