Translation of the book to Spanish #785
Conversation
ovas04
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
spier,
robtuley and
yuhattor
as code owners
|
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
… the toc generation. Also regenerate the toc for Spanish.
|
@ovas04 I put up a preview of your Spanish content on our staging site. There you can check how it looks like in our hosting platform (we use gitbook): https://innersourcecommons.gitbook.io/innersource-patterns-staging/es-test FYI I had to copy your branch into our repo, so that I could generate this preview. If you want to make changes, you can make them to your own branch though (this PR here). Besides that I will try to find somebody who can do a review of the content in Spanish (as I don't speak that language). Or do you have somebody that would be interested and willing to review your Spanish translations? |
There was a problem hiding this comment.
From a technical perspective your PR looks great already @ovas04! At least from the quick check that I did, the content seems to render correctly in our preview site. 🥳
Now let's wait and see if we can get some other Spanish speakers in the community to give this a review, so that we have at least a 2nd pair of eyes on it :)
Besides that, I added you as a translation lead for the Spanish translation. This just means that you would get an alert if anybody proposes a change/fix to the translation after it goes live. Would that work for you?
If you like, we can also translate the cover image of the book. Just let me know which text I should use for title and subtitle. I have the originals for that cover image somewhere, and can create the Spanish version for.
There was a problem hiding this comment.
TL;DR: LGTM
The content is good enough and there is always space for improvement, but the content is live and the changes should be minimal (as Spanish native speaker some sentences could be changed, but it is fine). I reviewed the whole content from the PR layout, and I would like to take a look of the testing site including the whole content (and reviews done) before publishing online. Then I can confirm and approve everything.
I would like to congratulate @ovas04 for his amazing job and flexiblity to adapt my comments. I know that he is the main contributor, just wondering if I could be part of the footer to support in the future any new translation. Suggesting from the ignorance about the rules to add names in the translated pages.
- **2025-04-03** - Traducción [Roman Martin Gil](https://github.com/rmarting)
PS: Just reported the #788 to satisfy the workflows. Not sure if it is a blocker to promote the content.
I just finished, @rmarting. Thanks a lot for the feedback and corrections. I think you truly deserve to be added as an author, and I'm happy to do it. If there aren't any more corrections, @spier, I'm comfortable continuing :) |
|
You two are amazing. It was very cool to see this smooth collaboration from the sidelines :) I can get this PR merged by the end of the week and will then bring the Spanish translation live. |
|
@ovas04 @rmarting I regenerated the table of content and the mindmap. Now the latest version of this branch is up on the preview site. |
|
|
|
@ovas04 @rmarting this is now live here: Amazing! I will do some more promotion of this tomorrow in our Slack, and will try to get this shared via our social channels as well. |
Add Spanish translations for:
Modify the workflow to include Spanish language support