Skip to content

Update changed link #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Update changed link #477

merged 4 commits into from
Nov 1, 2022

Conversation

robtuley
Copy link
Collaborator

@robtuley robtuley commented Oct 30, 2022

This PR simply updates a link that has changed. Apologies I should have left a redirect there.

EDIT: the PR link checker status check was failing, so this PR also adds a fix. This looks like it was introduced in #471 but looks like it has a bug in it when multiple *.md files are touched: the find command returns a newline separated list of md files when what is required is a space spearated one so just added a quick fix for that.

@robtuley robtuley added the Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR label Oct 30, 2022
@robtuley robtuley self-assigned this Oct 30, 2022
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link fix @robtuley!

Also great that you found the bug in the GitHub Action. Great catch!
Looks like we need to look for better ways to test those :)

I left two comments inline where it looks like you changed some markdown formatting that isn't necessarily related to this PR. As part of that is related to the Japanese translation, and I don't speak that language, I am not sure if this will look correct to Japanese readers.

@robtuley
Copy link
Collaborator Author

robtuley commented Nov 1, 2022

Yes my IDE made a mess of that by having a different markdown auto-formatter applying on save to the files I touched. Reverted those auto-changes now so diff should just be 2 x URL corrections and single-line bugfix to PR url checker.

@robtuley robtuley requested a review from spier November 1, 2022 13:39
@spier spier merged commit 0bc38f3 into main Nov 1, 2022
@spier spier deleted the fix-dead-flutter-url branch November 1, 2022 15:47
@spier
Copy link
Member

spier commented Nov 1, 2022

Yes my IDE made a mess of that by having a different markdown auto-formatter applying on save to the files I touched. Reverted those auto-changes now so diff should just be 2 x URL corrections and single-line bugfix to PR url checker.

Awesome. Your fix is merged now.

Would there be a way to tell your IDE with markdown formatting we use?
We have this file but apparently more than that is required? https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/.markdownlint.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type - Maintenance / Cleanup Maintaining / cleaning the repo is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants