shared-code-repo-different-from-build-repo.md - Moved to InnerSource as a term, changed formatting, shortened name #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this pattern does need a bit of love. I only made some first changes to the name "InnerSource", changed some formatting and shortened the name. However I believe the solutions given are incomplete in particular wrt. build chain solutions to the issue. It might make sense to mention explicit release naming and numbering schemes. It might make sense to mention the option of setting up build systems to trigger new builds on upstream code changes or upstream releases.
MaineC
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
spier and
robtuley
as code owners
spier
reviewed
Apr 29, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Apr 29, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Apr 29, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Apr 29, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
reviewed
Apr 29, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
added
the
📖 Type - Content Work
spier
added
the
1-initial
spier
changed the title
spier
reviewed
Oct 31, 2022
patterns/1-initial/shared-code-repo-different-from-build-repo.md
Outdated
Show resolved
Hide resolved
spier
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
@MaineC I would be happy to merge this as is.
You mention that "the solutions given are incomplete". If you have ideas for how to extend the Solution, that would be fantastic. In the interest of shorter cycles, I would suggest to already merge this PR, and leave further improvements to future PRs.
What do you think?
|
@MaineC I am going ahead and merging this PR, to get the improvements into the main line. If you have any other experiences related to this pattern, we would love to hear them (also see questions above). Out of curiosity: How did you come across this pattern in the first place? Is this a challenge that you have or solved in your org? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this pattern does need a bit of love. I only made some first changes to the name "InnerSource", changed some formatting and shortened the name.
However I believe the solutions given are incomplete in particular wrt. build chain solutions to the issue: