Skip to content

Introducing Pattern associated with InnerSource project fitness #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 12, 2021

Conversation

tapjdey
Copy link
Contributor

@tapjdey tapjdey commented Feb 9, 2021

This pattern should help with finding the appropriate pilot projects and assessing the suitability of candidate InnerSource projects based on the "InnerSource project Fitness" tool. As requested by @spier

@tapjdey
Copy link
Contributor Author

tapjdey commented Feb 9, 2021

Not sure what the link checker is complaining about, all links seem to work.

@spier
Copy link
Member

spier commented Feb 9, 2021

Thanks for pitching this pattern @tapjdey.

Could you please rename the file to good-first-project.md? Some of the tools we use related to the patterns maybe have issues with spaces in the filenames.

If you do this in the commandline it would be something like
git mv Good\ First\ Project.md good-first-project.md

As for the Link Checker, don't worry about it, we can figure that out later.
The error message is:

https://ulir.ul.ie/bitstream/handle/10344/4443/Stol_2014_inner.pdf?sequence=2
		X509: certificate signed by unknown authority

@spier
Copy link
Member

spier commented Feb 9, 2021

I will wait with more detailed feedback on the content until after you have renamed the file. Otherwise I am afraid that my inline comments might not get displayed correctly. :)

One high level thought already:

I believe we could make the pattern more generally applicable, if we manage to untie it a bit more from the specific implementation of the fitness score. e.g. if we could explain what makes for a good assessment of "InnerSource-readiness" of a single project, and then explain the different examples side by side. Something like:

a) Stol and Fitzgerald presented a set of nine key factors ...
b) Silona Bonewald's checklist ...
c) Criteria listed in Start as Experiment ...

And then finally we would of course list how your fitness score is synthesising (a)+(b) into a single solution (if I understand it correctly).

Not sure if explained that approach well?
I can try to draft it in a bit more detail if that helps.

@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Feb 9, 2021
@tapjdey
Copy link
Contributor Author

tapjdey commented Feb 10, 2021

@spier I have changed the file name as you requested. I have also added more content. It might be a bit too long and needs trimming, but let me know what you think.

Co-authored-by: Sebastian Spier <github@spier.hu>
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tapjdey. Fantastic first version already.

I made some non-controversial formatting changes myself.

Left other comments for you to review.

tapjdey and others added 5 commits February 11, 2021 10:45
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
@spier
Copy link
Member

spier commented Feb 11, 2021

@tapjdey I left some more suggestions. Most of them trying to make the text a bit simpler. Take a look :)

After your review, I think we should not word-smith this much further. For an initial pattern this is already great. So let's get this out into the world, so that we can get more feedback from others.

Could you please also add a link to this pattern in the README in this group, so that readers of our repo can find the pattern more easily?

I can come back to this tomorrow and help to get this over the finish line.

tapjdey and others added 6 commits February 11, 2021 22:37
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
@tapjdey
Copy link
Contributor Author

tapjdey commented Feb 11, 2021

@spier Thank you for your help with this! I have reviewed all the suggestions.

@spier spier merged commit b250ccc into InnerSourceCommons:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants