Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ink not building from source #118

Closed
aThorp96 opened this issue Dec 11, 2019 · 3 comments
Closed

Ink not building from source #118

aThorp96 opened this issue Dec 11, 2019 · 3 comments
Assignees
Labels

Comments

@aThorp96
Copy link

Describe the bug
When building ink from source there are a number of errors related to the CLI library. Is there a specific version I need to be building against?
I have already begun patching these errors, but many seem to lie with the CLI library so I wanted to check here before branching.

Error:

aht ~/code/go/src/github.com/inkproject/ink >go build
# github.com/inkproject/ink
./main.go:52:5: app.Author undefined (type *cli.App has no field or method Author)
./main.go:53:5: app.Email undefined (type *cli.App has no field or method Email)
./main.go:108:17: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:112:17: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:116:17: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:120:17: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:124:17: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:129:19: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:133:19: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:137:19: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:137:19: too many errors

To Reproduce
Steps to reproduce the behavior:

  1. Be running go 1.13.3
  2. Collect source code with go get github.com/InkProject/ink
  3. If go does not attempt compilation upon download, cd to the source code and run go build.
  4. See error

Expected behavior
This should build the source code and result in a binary executable.

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
@dr4g0nsr
Copy link
Contributor

I'm experiencing exact same problem on go 1.13/windows.

@dr4g0nsr
Copy link
Contributor

I made pull request that fixes this:
#119

@imeoer
Copy link
Member

imeoer commented Dec 21, 2019

useful fix, thanks @dr4g0nsr for the contribution, could you share your blog link here?

@imeoer imeoer closed this as completed Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants