Adds tests regarding negative integers in numerics.

Author: psuong

Common.Tests/NumericUtilsTests.cs

@@ -5,7 +5,7 @@ namespace CarteDiem.Common.Tests {
     public unsafe class NumericUtilTests {
 
         [Test]
-        public void CharEqualsDigit() {
+        public void CharEqualsPositiveDigit() {
             int value = 1234567890;
 
             char* actual = stackalloc char[10];
@@ -15,13 +15,12 @@ public void CharEqualsDigit() {
             string expected = value.ToString();
 
             for (int i = 0; i < count; i++) {
-                UnityEngine.Debug.Log(actual[i]);
                 Assert.AreEqual(expected[i], actual[i], "Mismatched digits");
             }
         }
 
         [Test]
-        public void CharEqualsDigitWithExcess() {
+        public void CharEqualsPositiveDigitWithExcess() {
             int value = 12345;
 
             char* actual = stackalloc char[15];
@@ -33,5 +32,31 @@ public void CharEqualsDigitWithExcess() {
                 Assert.AreEqual(exepected[i], actual[i], "Mismatched digits");
             }
         }
+
+        [Test]
+        public void CharEqualsNegativeDigits() {
+            int value = -12345;
+
+            char* actual = stackalloc char[6];
+            value.ToCharArray(actual, 6, out int count);
+            string expected = value.ToString();
+
+            for (int i = 0; i < count; i++) {
+                Assert.AreEqual(expected[i], actual[i], "Mismatch digits");
+            }
+        }
+
+        [Test]
+        public void CharEqualsNegativeDigitsWIthExcess() {
+            int value = -1234569;
+
+            char* actual = stackalloc char[15];
+            value.ToCharArray(actual, 15, out int count);
+            string expected = value.ToString();
+
+            for (int i = 0; i < count; i++) {
+                Assert.AreEqual(expected[i], actual[i], "Mismatch digits");
+            }
+        }
     }
 }

Common/NumericUtils.cs

@@ -1,4 +1,5 @@
 using Unity.Collections;
+using Unity.Mathematics;
 
 namespace CarteDiem.Common {
 
@@ -11,6 +12,9 @@ public unsafe static class NumericUtils {
         /// <param name="length">The size of the buffer</param>
         /// <param name="count">The total number of counted digits</param>
         public static void ToCharArray(this int value, char* ptr, in int length, out int count) {
+            var offset = value < 0 ? 0 : -1;
+
+            value = math.abs(value);
             var stack = new NativeList<char>(Allocator.Temp);
             do {
                 var mod = value % 10;
@@ -21,14 +25,20 @@ public static void ToCharArray(this int value, char* ptr, in int length, out int
             } while (value != 0);
 
             for (int i = 0; i < stack.Length; i++) {
-                var flipped = stack.Length - 1 - i;
+                var flipped = stack.Length + offset - i;
 
                 if (flipped < length) {
                     ptr[flipped] = stack[i];
                 }
             }
 
             count = stack.Length;
+
+            if (offset >= 0) {
+                ptr[0] = '-';
+                count++;
+            }
+
             stack.Dispose();
         }
 

Common/UGUIDots.Common.asmdef

@@ -1,7 +1,8 @@
 {
     "name": "UGUIDots.Common",
     "references": [
-        "GUID:e0cd26848372d4e5c891c569017e11f1"
+        "GUID:e0cd26848372d4e5c891c569017e11f1",
+        "GUID:d8b63aba1907145bea998dd612889d6b"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],