Add helm ci test (#432)

Co-authored-by: liangyuanpeng <gcslyp@gmail.com>

Author: kerthcet

.github/workflows/helm-chart-verify.yaml

@@ -0,0 +1,40 @@
+name: Helm Chart Verify
+
+env:
+  HELM_VERSION: v3.17.3
+
+on:
+  push:
+    # Exclude branches created by Dependabot to avoid triggering current workflow
+    # for PRs initiated by Dependabot.
+    branches-ignore:
+      - 'dependabot/**'
+  pull_request:
+    # paths:
+    #   - "charts/**"
+
+permissions:
+  contents: read
+
+jobs:
+  test-deploy-with-helm:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - name: Set up Helm
+        uses: azure/setup-helm@v4
+        with:
+          version: ${{ env.HELM_VERSION }}
+
+      - name: Run
+        run: |
+          make test-deploy-with-helm

Makefile

@@ -135,10 +135,12 @@ test-integration: manifests fmt vet envtest ginkgo ## Run integration tests.
 	$(GINKGO) --junit-report=junit.xml --output-dir=$(ARTIFACTS) -v $(INTEGRATION_TARGET)
 
 .PHONY: test-e2e
-# FIXME: we should install lws CRD.
 test-e2e: kustomize manifests fmt vet envtest ginkgo kind-image-build
 	E2E_KIND_NODE_VERSION=$(E2E_KIND_NODE_VERSION) KIND_CLUSTER_NAME=$(KIND_CLUSTER_NAME) KIND=$(KIND) KUBECTL=$(KUBECTL) KUSTOMIZE=$(KUSTOMIZE) GINKGO=$(GINKGO) USE_EXISTING_CLUSTER=$(USE_EXISTING_CLUSTER) IMAGE_TAG=$(IMG) ENVTEST_LWS_VERSION=$(ENVTEST_LWS_VERSION) ./hack/e2e-test.sh
 
+test-deploy-with-helm: kind-image-build
+	E2E_KIND_NODE_VERSION=$(E2E_KIND_NODE_VERSION) KIND_CLUSTER_NAME=$(KIND_CLUSTER_NAME) KIND=$(KIND) KUBECTL=$(KUBECTL) USE_EXISTING_CLUSTER=$(USE_EXISTING_CLUSTER) IMAGE_TAG=$(IMG) TAG=$(GIT_TAG) ./hack/test-deploy-with-helm.sh
+
 GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
 GOLANGCI_LINT_VERSION ?= v1.63.4
 golangci-lint:
@@ -269,6 +271,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest
 ## Tool Versions
 KUSTOMIZE_VERSION ?= v5.2.1
 CONTROLLER_TOOLS_VERSION ?= v0.16.1
+HELM_EXT_OPTS ?=
 
 .PHONY: kustomize
 kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary. If wrong version is installed, it will be removed before downloading.
@@ -321,7 +324,7 @@ helm: manifests kustomize helmify
 
 .PHONY: helm-install
 helm-install: helm
-	helm upgrade --namespace llmaz-system --install llmaz ./chart -f ./chart/values.global.yaml --dependency-update --create-namespace
+	helm upgrade --namespace llmaz-system --install llmaz ./chart -f ./chart/values.global.yaml --dependency-update --create-namespace $(HELM_EXT_OPTS)
 
 .PHONY: helm-upgrade
 helm-upgrade: image-push artifacts helm-install

hack/test-deploy-with-helm.sh

@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
+
+export CWD=$(pwd)
+function cleanup {
+    if [ $USE_EXISTING_CLUSTER == 'false' ]
+    then
+        $KIND delete cluster --name $KIND_CLUSTER_NAME
+    fi
+}
+function startup {
+    if [ $USE_EXISTING_CLUSTER == 'false' ]
+    then
+        $KIND create cluster --name $KIND_CLUSTER_NAME --image $E2E_KIND_NODE_VERSION --config ./hack/kind-config.yaml
+    fi
+}
+function kind_load {
+    $KIND load docker-image $IMAGE_TAG --name $KIND_CLUSTER_NAME
+}
+function deploy {
+    cd $CWD
+    HELM_EXT_OPTS='--set controllerManager.manager.image.tag=${TAG}' make helm-install
+    $KUBECTL wait --timeout=30m --for=condition=ready pods --namespace=llmaz-system -l app.kubernetes.io/component!=open-webui,app!=certgen
+    echo "all pods of llmaz-system is ready..."
+    $KUBECTL get pod -n llmaz-system
+}
+trap cleanup EXIT
+startup
+kind_load
+deploy

test/config/lws/leaderworkerset.yaml

@@ -16664,7 +16664,7 @@ metadata:
   name: lws-controller-manager
   namespace: lws-system
 spec:
-  replicas: 2
+  replicas: 1
   selector:
     matchLabels:
       control-plane: controller-manager
@@ -16680,7 +16680,7 @@ spec:
         - --zap-log-level=2
         command:
         - /manager
-        image: registry.k8s.io/lws/lws:v0.5.0
+        image: registry.k8s.io/lws/lws:v0.6.1
         livenessProbe:
           httpGet:
             path: /healthz