Skip to content

Commit 6b1f12a

Browse files
Modified the authorize url to contain entire request uri
Signed-off-by: SajidMannikeri17 <mannikerisazz@gmail.com>
1 parent cbb1bea commit 6b1f12a

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

sign-in-with-esignet/src/lib/SignInWithEsignet/ISignInWithEsignetProps.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ interface OidcConfigProp {
1919
}
2020

2121
interface CallbackFunctionProp {
22-
(clientId: string): Promise<string>;
22+
(clientId: string, state?: string, ui_locales?: string): Promise<string>;
2323
}
2424

2525
interface ButtonConfigProp {

sign-in-with-esignet/src/lib/SignInWithEsignet/SignInWithEsignet.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -381,13 +381,6 @@ function buildErrorRedirectUrl(
381381
)}&error=${encodeURIComponent(errorCode)}`;
382382
}
383383

384-
function extractRequestUriValue(requestUri: string): string {
385-
if (requestUri && requestUri.includes(":")) {
386-
return requestUri.substring(requestUri.lastIndexOf(":") + 1);
387-
}
388-
return requestUri;
389-
}
390-
391384
function promiseWithTimeout<T>(
392385
promise: Promise<T>,
393386
ms: number
@@ -408,7 +401,11 @@ async function par_callback(
408401
return errorMessage.clientIdMissing;
409402
}
410403
try {
411-
return await callbackFunction(oidcConfig.client_id);
404+
return await callbackFunction(
405+
oidcConfig.client_id,
406+
oidcConfig.state,
407+
oidcConfig.ui_locales
408+
);
412409
} catch (error) {
413410
return errorMessage.requestUriFailed;
414411
}
@@ -451,8 +448,11 @@ const SignInWithEsignet = async ({
451448
typeof result === "string" &&
452449
result.startsWith("urn:ietf:params:oauth:request_uri:")
453450
) {
454-
const requestUriValue = extractRequestUriValue(result);
455-
urlToNavigate = `${oidcConfig.authorizeUri}?client_id=${oidcConfig.client_id}&request_uri=${requestUriValue}`;
451+
urlToNavigate = `${
452+
oidcConfig.authorizeUri
453+
}?client_id=${encodeURIComponent(
454+
oidcConfig.client_id
455+
)}&request_uri=${encodeURIComponent(result)}`;
456456
window.location.href = urlToNavigate;
457457
return;
458458
}

0 commit comments

Comments
 (0)