Skip to content

Commit eb465f2

Browse files
committed
Move tags "message" and "backtrace" in "rails.exceptions" series to values
1 parent f119d88 commit eb465f2

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

lib/influxdb-rails.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,17 @@ def report_exception_unless_ignorable(e, env = {})
6464
# rubocop:disable Metrics/MethodLength
6565

6666
def report_exception(e, env = {})
67+
timestamp = InfluxDB::Rails.current_timestamp
6768
env = influxdb_request_data if env.empty? && defined? influxdb_request_data
6869
exception_presenter = ExceptionPresenter.new(e, env)
6970
log :info, "Exception: #{exception_presenter.to_json[0..512]}..."
7071

71-
tags = exception_presenter.context.merge(exception_presenter.dimensions)
72-
timestamp = tags.delete(:time)
72+
ex_data =
7373

7474
client.write_point \
7575
configuration.series_name_for_exceptions,
76-
values: { ts: timestamp },
77-
tags: tags,
76+
values: exception_presenter.values.merge(ts: timestamp),
77+
tags: exception_presenter.context.merge(exception_presenter.dimensions),
7878
timestamp: timestamp
7979
rescue StandardError => e
8080
log :info, "[InfluxDB::Rails] Something went terribly wrong." \

lib/influxdb/rails/exception_presenter.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,10 @@ def initialize(e, params = {})
3232

3333
def context # rubocop:disable Metrics/MethodLength
3434
c = {
35-
time: InfluxDB::Rails.current_timestamp,
3635
application_name: InfluxDB::Rails.configuration.application_name,
3736
application_root: InfluxDB::Rails.configuration.application_root,
3837
framework: InfluxDB::Rails.configuration.framework,
3938
framework_version: InfluxDB::Rails.configuration.framework_version,
40-
message: @exception.message,
41-
backtrace: JSON.generate(@backtrace.to_a),
4239
language: "Ruby",
4340
language_version: "#{RUBY_VERSION}-p#{RUBY_PATCHLEVEL}",
4441
custom_data: @custom_data,
@@ -58,6 +55,13 @@ def dimensions
5855
}.merge(@dimensions)
5956
end
6057

58+
def values
59+
{
60+
exception_message: @exception.message,
61+
exception_backtrace: JSON.generate(@backtrace.to_a),
62+
}
63+
end
64+
6165
def request_data
6266
{
6367
params: @params,

0 commit comments

Comments
 (0)