Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language selector to page header #278

Closed
xa31er opened this issue Oct 20, 2024 · 7 comments
Closed

Move language selector to page header #278

xa31er opened this issue Oct 20, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@xa31er
Copy link
Contributor

xa31er commented Oct 20, 2024

The way that it is now, it is likely that people will miss it, because it is tucked down at the bottom of the page.

@Naviary2
Copy link
Member

I can't remember if the first time someone visits the site it auto-sets their preferred language or not.

@Heinrich-XIAO
Copy link
Contributor

I don't think it does. I set my default language to french and cleared the cookies on infinite chess and ctrl-shift-r'd and it was still in en-US

@xa31er
Copy link
Contributor Author

xa31er commented Oct 20, 2024

We could also use this opportunity to implement a settings menu and solve issues #101 and #102 .

@Naviary2
Copy link
Member

I am wanting to overhaul the design of the website. I think I'll make the settings menu first though, I'll try to design it for longevity.

And yes, users language should be auto-selected the first time they visit the website. That slightly decreases the need to move the language selector to the header.. but perhaps in the future design overhaul we could add a globe icon for this

@Naviary2 Naviary2 added the enhancement New feature or request label Oct 21, 2024
@xa31er
Copy link
Contributor Author

xa31er commented Oct 21, 2024

Yeah , I don't think it's that urgent

@Naviary2
Copy link
Member

Naviary2 commented Nov 2, 2024

This has already been implemented in the themes branch, but I'll wait to close this until it's merged.

@Naviary2
Copy link
Member

Naviary2 commented Dec 3, 2024

Oh yeah this is done now, forgot about this lol.
The Themes update completed so many issues

@Naviary2 Naviary2 closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants