Status bar displays time in 12 or 24 hour format based on settings #821
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riksu9000
approved these changes
Nov 12, 2021
Closed
Contributor
|
Works nicely. This is a great improvement. |
1 task
1 task
1 task
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the status bar display time in the correct format per the "Time format" setting.
New function is added to DateTime called FormattedTime returns a string with the correct time format, so the caller doesn't need to check the settings directly.
I had to remove one unused include from Settings.h to avoid circular include problems.
This is a scaled-back version of #786 (per @Riksu9000 's suggestion) to fix the time display while thinking about how to handle other changes to the status bar.