applied ReSharper suggestions

Author: InfectedBytes

Assets/Plugins/Editor/GameJolt/SettingsEditor.cs

@@ -4,6 +4,7 @@
 using UnityEngine;
 using Random = System.Random;
 
+// ReSharper disable once CheckNamespace
 namespace GameJolt.Editor {
 	[CustomEditor(typeof(Settings))]
 	public class SettingsEditor : UnityEditor.Editor {

Assets/Plugins/Editor/GameJolt/Tools.cs

@@ -3,6 +3,7 @@
 using UnityEditor;
 using GameJolt.API;
 
+// ReSharper disable once CheckNamespace
 namespace GameJolt.Editor {
 	public class Tools : MonoBehaviour {
 		private const string DefaultSettingsPath = "Assets/Plugins/GameJolt/GJAPISettings.asset";
@@ -38,6 +39,7 @@ public static void Manager() {
 					Selection.activeObject = clone;
 
 					if(FindObjectOfType<EventSystem>() == null) {
+						// ReSharper disable once ObjectCreationAsStatement
 						new GameObject(
 							"EventSystem",
 							typeof(EventSystem),

Assets/Plugins/GameJolt/Scripts/API/Misc.cs

@@ -7,17 +7,17 @@ namespace GameJolt.API {
 	/// Misc API methods.
 	/// </summary>
 	public static class Misc {
-		private static readonly Dictionary<string, Sprite> spriteCache = new Dictionary<string, Sprite>();
-		private static readonly Dictionary<string, Action<Sprite>> openRequests = new Dictionary<string, Action<Sprite>>();
+		private static readonly Dictionary<string, Sprite> SpriteCache = new Dictionary<string, Sprite>();
+		private static readonly Dictionary<string, Action<Sprite>> OpenRequests = new Dictionary<string, Action<Sprite>>();
 
 		/// <summary>
 		/// Destroys all sprites in the spritecache.
 		/// </summary>
 		public static void ClearSpriteCache() {
-			foreach(var sprite in spriteCache.Values) {
+			foreach(var sprite in SpriteCache.Values) {
 				UnityEngine.Object.Destroy(sprite);
 			}
-			spriteCache.Clear();
+			SpriteCache.Clear();
 		}
 
 		/// <summary>
@@ -28,24 +28,24 @@ public static void ClearSpriteCache() {
 		public static void DownloadImage(string url, Action<Sprite> callback) {
 			// check if the sprite is already cached
 			Sprite cachedSprite;
-			if(spriteCache.TryGetValue(url, out cachedSprite)) {
+			if(SpriteCache.TryGetValue(url, out cachedSprite)) {
 				if(cachedSprite) {
 					// check if sprite is not destroyed
 					if(callback != null) callback(cachedSprite);
 					return;
 				}
 				// sprite was cached, but it is already destroyed
-				spriteCache.Remove(url);
+				SpriteCache.Remove(url);
 			}
 
 			// check if there is already an open request
 			Action<Sprite> cachedMulticast;
-			if(callback != null && openRequests.TryGetValue(url, out cachedMulticast)) {
+			if(callback != null && OpenRequests.TryGetValue(url, out cachedMulticast)) {
 				// there is already a request for that image
-				openRequests[url] = cachedMulticast + callback; // add callback to multicast
+				OpenRequests[url] = cachedMulticast + callback; // add callback to multicast
 			} else {
 				// no open request -> initiate one
-				openRequests[url] = callback;
+				OpenRequests[url] = callback;
 				GameJoltAPI.Instance.StartCoroutine(GameJoltAPI.Instance.GetRequest(url, Core.ResponseFormat.Texture, response => {
 					Sprite sprite = null;
 					if(response.Success) {
@@ -54,12 +54,12 @@ public static void DownloadImage(string url, Action<Sprite> callback) {
 							new Rect(0, 0, response.Texture.width, response.Texture.height),
 							new Vector2(.5f, .5f),
 							response.Texture.width);
-						spriteCache[url] = sprite;
+						SpriteCache[url] = sprite;
 					}
 
 					Action<Sprite> multicast;
-					if(openRequests.TryGetValue(url, out multicast)) {
-						openRequests.Remove(url);
+					if(OpenRequests.TryGetValue(url, out multicast)) {
+						OpenRequests.Remove(url);
 						multicast(sprite);
 					}
 				}));

Assets/Plugins/GameJolt/Scripts/External/SimpleJSON.cs

@@ -8,6 +8,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
+// ReSharper disable All
 
 namespace GameJolt.External.SimpleJSON
 {

Assets/Plugins/GameJolt/Scripts/UI/Controllers/BaseWindow.cs

@@ -3,10 +3,10 @@
 
 namespace GameJolt.UI.Controllers {
 	public abstract class BaseWindow : MonoBehaviour {
-		protected Animator animator;
+		protected Animator Animator;
 
 		public void Init(Animator animator) {
-			this.animator = animator;
+			Animator = animator;
 		}
 
 		public abstract void Show(Action<bool> callback);

Assets/Plugins/GameJolt/Scripts/UI/Controllers/LeaderboardsWindow.cs

@@ -23,8 +23,8 @@ public override void Show(Action<bool> callback) {
 		}
 
 		public void Show(Action<bool> callback, int? activeTable, int[] visibleTables) {
-			animator.SetTrigger("Leaderboards");
-			animator.SetTrigger("ShowLoadingIndicator");
+			Animator.SetTrigger("Leaderboards");
+			Animator.SetTrigger("ShowLoadingIndicator");
 			this.callback = callback;
 
 			Scores.GetTables(tables => {
@@ -52,7 +52,7 @@ public void Show(Action<bool> callback, int? activeTable, int[] visibleTables) {
 					SetScores(activeId);
 				} else {
 					// TODO: Show error notification
-					animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("HideLoadingIndicator");
 					Dismiss(false);
 				}
 			});
@@ -69,7 +69,7 @@ private int GetActiveTableId(Table[] tables, int? activeTable) {
 		}
 
 		public override void Dismiss(bool success) {
-			animator.SetTrigger("Dismiss");
+			Animator.SetTrigger("Dismiss");
 			if(callback != null) {
 				callback(success);
 				callback = null;
@@ -81,8 +81,8 @@ public void ShowTab(int index) {
 			TabsContainer.GetChild(currentTab).GetComponent<TableButton>().SetActive(false);
 			currentTab = index;
 
-			animator.SetTrigger("Lock");
-			animator.SetTrigger("ShowLoadingIndicator");
+			Animator.SetTrigger("Lock");
+			Animator.SetTrigger("ShowLoadingIndicator");
 
 			// Request new scores.
 			SetScores(tableIDs[currentTab]);
@@ -101,11 +101,11 @@ private void SetScores(int tableId) {
 						ScoresScrollRect.content.GetChild(i).GetComponent<ScoreItem>().Init(scores[i]);
 					}
 
-					animator.SetTrigger("HideLoadingIndicator");
-					animator.SetTrigger("Unlock");
+					Animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("Unlock");
 				} else {
 					// TODO: Show error notification
-					animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("HideLoadingIndicator");
 					Dismiss(false);
 				}
 			}, tableId, 50);

Assets/Plugins/GameJolt/Scripts/UI/Controllers/SignInWindow.cs

@@ -19,7 +19,7 @@ public override void Show(Action<bool> callback) {
 
 		public void Show(Action<bool> signedInCallback, Action<bool> userFetchedCallback) {
 			ErrorMessage.enabled = false;
-			animator.SetTrigger("SignIn");
+			Animator.SetTrigger("SignIn");
 			this.signedInCallback = signedInCallback;
 			this.userFetchedCallback = userFetchedCallback;
 			string username, token;
@@ -30,7 +30,7 @@ public void Show(Action<bool> signedInCallback, Action<bool> userFetchedCallback
 		}
 
 		public override void Dismiss(bool success) {
-			animator.SetTrigger("Dismiss");
+			Animator.SetTrigger("Dismiss");
 			if(signedInCallback != null) {
 				signedInCallback(success);
 				signedInCallback = null;
@@ -44,8 +44,8 @@ public void Submit() {
 				ErrorMessage.text = "Empty username and/or token.";
 				ErrorMessage.enabled = true;
 			} else {
-				animator.SetTrigger("Lock");
-				animator.SetTrigger("ShowLoadingIndicator");
+				Animator.SetTrigger("Lock");
+				Animator.SetTrigger("ShowLoadingIndicator");
 
 				var user = new API.Objects.User(UsernameField.text.Trim(), TokenField.text.Trim());
 				user.SignIn(signInSuccess => {
@@ -57,8 +57,8 @@ public void Submit() {
 						ErrorMessage.enabled = true;
 					}
 
-					animator.SetTrigger("HideLoadingIndicator");
-					animator.SetTrigger("Unlock");
+					Animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("Unlock");
 				}, userFetchedSuccess => {
 					if(userFetchedCallback != null) {
 						// This will potentially be called after a user dismissed the window..

Assets/Plugins/GameJolt/Scripts/UI/Controllers/TrophiesWindow.cs

@@ -11,8 +11,8 @@ public class TrophiesWindow : BaseWindow {
 		private Action<bool> callback;
 
 		public override void Show(Action<bool> callback) {
-			animator.SetTrigger("Trophies");
-			animator.SetTrigger("ShowLoadingIndicator");
+			Animator.SetTrigger("Trophies");
+			Animator.SetTrigger("ShowLoadingIndicator");
 			this.callback = callback;
 
 			Trophies.Get(trophies => {
@@ -30,18 +30,18 @@ public override void Show(Action<bool> callback) {
 						Container.GetChild(i).GetComponent<TrophyItem>().Init(trophies[i]);
 					}
 
-					animator.SetTrigger("HideLoadingIndicator");
-					animator.SetTrigger("Unlock");
+					Animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("Unlock");
 				} else {
 					// TODO: Show error notification
-					animator.SetTrigger("HideLoadingIndicator");
+					Animator.SetTrigger("HideLoadingIndicator");
 					Dismiss(false);
 				}
 			});
 		}
 
 		public override void Dismiss(bool success) {
-			animator.SetTrigger("Dismiss");
+			Animator.SetTrigger("Dismiss");
 			if(callback != null) {
 				callback(success);
 				callback = null;