Skip to content

Commit efd6ff0

Browse files
chore: simplify examples involving lists (#696)
1 parent e5243b4 commit efd6ff0

36 files changed

+2122
-2447
lines changed

increase-java-core/src/test/kotlin/com/increase/api/models/AchPrenotificationTest.kt

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,15 @@ class AchPrenotificationTest {
2323
.creditDebitIndicator(AchPrenotification.CreditDebitIndicator.CREDIT)
2424
.effectiveDate(null)
2525
.idempotencyKey(null)
26-
.notificationsOfChange(
27-
listOf(
28-
AchPrenotification.NotificationsOfChange.builder()
29-
.changeCode(
30-
AchPrenotification.NotificationsOfChange.ChangeCode
31-
.INCORRECT_ACCOUNT_NUMBER
32-
)
33-
.correctedData("32")
34-
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
35-
.build()
36-
)
26+
.addNotificationsOfChange(
27+
AchPrenotification.NotificationsOfChange.builder()
28+
.changeCode(
29+
AchPrenotification.NotificationsOfChange.ChangeCode
30+
.INCORRECT_ACCOUNT_NUMBER
31+
)
32+
.correctedData("32")
33+
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
34+
.build()
3735
)
3836
.prenotificationReturn(
3937
AchPrenotification.PrenotificationReturn.builder()

increase-java-core/src/test/kotlin/com/increase/api/models/AchTransferCreateParamsTest.kt

Lines changed: 31 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,21 @@ class AchTransferCreateParamsTest {
2020
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
2121
.freeform(
2222
AchTransferCreateParams.Addenda.Freeform.builder()
23-
.entries(
24-
listOf(
25-
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
26-
.paymentRelatedInformation("x")
27-
.build()
28-
)
23+
.addEntry(
24+
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
25+
.paymentRelatedInformation("x")
26+
.build()
2927
)
3028
.build()
3129
)
3230
.paymentOrderRemittanceAdvice(
3331
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
34-
.invoices(
35-
listOf(
36-
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
37-
.Invoice
38-
.builder()
39-
.invoiceNumber("x")
40-
.paidAmount(0L)
41-
.build()
42-
)
32+
.addInvoice(
33+
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.Invoice
34+
.builder()
35+
.invoiceNumber("x")
36+
.paidAmount(0L)
37+
.build()
4338
)
4439
.build()
4540
)
@@ -84,26 +79,22 @@ class AchTransferCreateParamsTest {
8479
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
8580
.freeform(
8681
AchTransferCreateParams.Addenda.Freeform.builder()
87-
.entries(
88-
listOf(
89-
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
90-
.paymentRelatedInformation("x")
91-
.build()
92-
)
82+
.addEntry(
83+
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
84+
.paymentRelatedInformation("x")
85+
.build()
9386
)
9487
.build()
9588
)
9689
.paymentOrderRemittanceAdvice(
9790
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
98-
.invoices(
99-
listOf(
100-
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
101-
.Invoice
102-
.builder()
103-
.invoiceNumber("x")
104-
.paidAmount(0L)
105-
.build()
106-
)
91+
.addInvoice(
92+
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
93+
.Invoice
94+
.builder()
95+
.invoiceNumber("x")
96+
.paidAmount(0L)
97+
.build()
10798
)
10899
.build()
109100
)
@@ -146,26 +137,21 @@ class AchTransferCreateParamsTest {
146137
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
147138
.freeform(
148139
AchTransferCreateParams.Addenda.Freeform.builder()
149-
.entries(
150-
listOf(
151-
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
152-
.paymentRelatedInformation("x")
153-
.build()
154-
)
140+
.addEntry(
141+
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
142+
.paymentRelatedInformation("x")
143+
.build()
155144
)
156145
.build()
157146
)
158147
.paymentOrderRemittanceAdvice(
159148
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
160-
.invoices(
161-
listOf(
162-
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
163-
.Invoice
164-
.builder()
165-
.invoiceNumber("x")
166-
.paidAmount(0L)
167-
.build()
168-
)
149+
.addInvoice(
150+
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.Invoice
151+
.builder()
152+
.invoiceNumber("x")
153+
.paidAmount(0L)
154+
.build()
169155
)
170156
.build()
171157
)

increase-java-core/src/test/kotlin/com/increase/api/models/AchTransferTest.kt

Lines changed: 27 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -26,27 +26,21 @@ class AchTransferTest {
2626
.category(AchTransfer.Addenda.Category.FREEFORM)
2727
.freeform(
2828
AchTransfer.Addenda.Freeform.builder()
29-
.entries(
30-
listOf(
31-
AchTransfer.Addenda.Freeform.Entry.builder()
32-
.paymentRelatedInformation(
33-
"payment_related_information"
34-
)
35-
.build()
36-
)
29+
.addEntry(
30+
AchTransfer.Addenda.Freeform.Entry.builder()
31+
.paymentRelatedInformation("payment_related_information")
32+
.build()
3733
)
3834
.build()
3935
)
4036
.paymentOrderRemittanceAdvice(
4137
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.builder()
42-
.invoices(
43-
listOf(
44-
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
45-
.builder()
46-
.invoiceNumber("invoice_number")
47-
.paidAmount(0L)
48-
.build()
49-
)
38+
.addInvoice(
39+
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
40+
.builder()
41+
.invoiceNumber("invoice_number")
42+
.paidAmount(0L)
43+
.build()
5044
)
5145
.build()
5246
)
@@ -108,17 +102,14 @@ class AchTransferTest {
108102
.individualId(null)
109103
.individualName("Ian Crease")
110104
.network(AchTransfer.Network.ACH)
111-
.notificationsOfChange(
112-
listOf(
113-
AchTransfer.NotificationsOfChange.builder()
114-
.changeCode(
115-
AchTransfer.NotificationsOfChange.ChangeCode
116-
.INCORRECT_ACCOUNT_NUMBER
117-
)
118-
.correctedData("32")
119-
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
120-
.build()
121-
)
105+
.addNotificationsOfChange(
106+
AchTransfer.NotificationsOfChange.builder()
107+
.changeCode(
108+
AchTransfer.NotificationsOfChange.ChangeCode.INCORRECT_ACCOUNT_NUMBER
109+
)
110+
.correctedData("32")
111+
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
112+
.build()
122113
)
123114
.pendingTransactionId(null)
124115
.preferredEffectiveDate(
@@ -178,25 +169,20 @@ class AchTransferTest {
178169
.category(AchTransfer.Addenda.Category.FREEFORM)
179170
.freeform(
180171
AchTransfer.Addenda.Freeform.builder()
181-
.entries(
182-
listOf(
183-
AchTransfer.Addenda.Freeform.Entry.builder()
184-
.paymentRelatedInformation("payment_related_information")
185-
.build()
186-
)
172+
.addEntry(
173+
AchTransfer.Addenda.Freeform.Entry.builder()
174+
.paymentRelatedInformation("payment_related_information")
175+
.build()
187176
)
188177
.build()
189178
)
190179
.paymentOrderRemittanceAdvice(
191180
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.builder()
192-
.invoices(
193-
listOf(
194-
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
195-
.builder()
196-
.invoiceNumber("invoice_number")
197-
.paidAmount(0L)
198-
.build()
199-
)
181+
.addInvoice(
182+
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice.builder()
183+
.invoiceNumber("invoice_number")
184+
.paidAmount(0L)
185+
.build()
200186
)
201187
.build()
202188
)

increase-java-core/src/test/kotlin/com/increase/api/models/BookkeepingEntrySetCreateParamsTest.kt

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ class BookkeepingEntrySetCreateParamsTest {
1111
@Test
1212
fun createBookkeepingEntrySetCreateParams() {
1313
BookkeepingEntrySetCreateParams.builder()
14-
.entries(
15-
listOf(
16-
BookkeepingEntrySetCreateParams.Entry.builder()
17-
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
18-
.amount(100L)
19-
.build(),
20-
BookkeepingEntrySetCreateParams.Entry.builder()
21-
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
22-
.amount(-100L)
23-
.build()
24-
)
14+
.addEntry(
15+
BookkeepingEntrySetCreateParams.Entry.builder()
16+
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
17+
.amount(100L)
18+
.build()
19+
)
20+
.addEntry(
21+
BookkeepingEntrySetCreateParams.Entry.builder()
22+
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
23+
.amount(-100L)
24+
.build()
2525
)
2626
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
2727
.transactionId("transaction_uyrp7fld2ium70oa7oi")
@@ -32,17 +32,17 @@ class BookkeepingEntrySetCreateParamsTest {
3232
fun getBody() {
3333
val params =
3434
BookkeepingEntrySetCreateParams.builder()
35-
.entries(
36-
listOf(
37-
BookkeepingEntrySetCreateParams.Entry.builder()
38-
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
39-
.amount(100L)
40-
.build(),
41-
BookkeepingEntrySetCreateParams.Entry.builder()
42-
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
43-
.amount(-100L)
44-
.build()
45-
)
35+
.addEntry(
36+
BookkeepingEntrySetCreateParams.Entry.builder()
37+
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
38+
.amount(100L)
39+
.build()
40+
)
41+
.addEntry(
42+
BookkeepingEntrySetCreateParams.Entry.builder()
43+
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
44+
.amount(-100L)
45+
.build()
4646
)
4747
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
4848
.transactionId("transaction_uyrp7fld2ium70oa7oi")
@@ -70,17 +70,17 @@ class BookkeepingEntrySetCreateParamsTest {
7070
fun getBodyWithoutOptionalFields() {
7171
val params =
7272
BookkeepingEntrySetCreateParams.builder()
73-
.entries(
74-
listOf(
75-
BookkeepingEntrySetCreateParams.Entry.builder()
76-
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
77-
.amount(100L)
78-
.build(),
79-
BookkeepingEntrySetCreateParams.Entry.builder()
80-
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
81-
.amount(-100L)
82-
.build()
83-
)
73+
.addEntry(
74+
BookkeepingEntrySetCreateParams.Entry.builder()
75+
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
76+
.amount(100L)
77+
.build()
78+
)
79+
.addEntry(
80+
BookkeepingEntrySetCreateParams.Entry.builder()
81+
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
82+
.amount(-100L)
83+
.build()
8484
)
8585
.build()
8686
val body = params.getBody()

increase-java-core/src/test/kotlin/com/increase/api/models/BookkeepingEntrySetTest.kt

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ class BookkeepingEntrySetTest {
1515
.id("bookkeeping_entry_set_n80c6wr2p8gtc6p4ingf")
1616
.createdAt(OffsetDateTime.parse("2023-02-11T02:11:59Z"))
1717
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
18-
.entries(
19-
listOf(
20-
BookkeepingEntrySet.Entry.builder()
21-
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
22-
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
23-
.amount(1750L)
24-
.build(),
25-
BookkeepingEntrySet.Entry.builder()
26-
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
27-
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
28-
.amount(-1750L)
29-
.build()
30-
)
18+
.addEntry(
19+
BookkeepingEntrySet.Entry.builder()
20+
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
21+
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
22+
.amount(1750L)
23+
.build()
24+
)
25+
.addEntry(
26+
BookkeepingEntrySet.Entry.builder()
27+
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
28+
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
29+
.amount(-1750L)
30+
.build()
3131
)
3232
.idempotencyKey(null)
3333
.transactionId(null)

increase-java-core/src/test/kotlin/com/increase/api/models/CardDisputeListParamsTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class CardDisputeListParamsTest {
2525
.limit(1L)
2626
.status(
2727
CardDisputeListParams.Status.builder()
28-
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
28+
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
2929
.build()
3030
)
3131
.build()
@@ -48,7 +48,7 @@ class CardDisputeListParamsTest {
4848
.limit(1L)
4949
.status(
5050
CardDisputeListParams.Status.builder()
51-
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
51+
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
5252
.build()
5353
)
5454
.build()
@@ -64,7 +64,7 @@ class CardDisputeListParamsTest {
6464
expected.put("idempotency_key", "x")
6565
expected.put("limit", "1")
6666
CardDisputeListParams.Status.builder()
67-
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
67+
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
6868
.build()
6969
.forEachQueryParam { key, values -> expected.put("status.$key", values) }
7070
assertThat(params.getQueryParams()).isEqualTo(expected.build())

0 commit comments

Comments
 (0)